Bookmark menus not updated when their name is edited in the bookmark bar....

chrome/browser/cocoa/bookmark_menu_bridge.h

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // C++ controller for the bookmark menu; one per AppController (which
 // means there is only one).  When bookmarks are changed, this class
 // takes care of updating Cocoa bookmark menus.  This is not named
 // BookmarkMenuController to help avoid confusion between languages.
 // This class needs to be C++, not ObjC, since it derives from
 // BookmarkModelObserver.
@@ skipping 60 matching lines @@
                         NSString* title);
 
   // Helper for recursively adding items to our bookmark menu
   // All children of |node| will be added to |menu|.
   // TODO(jrg): add a counter to enforce maximum nodes added
   void AddNodeToMenu(const BookmarkNode* node, NSMenu* menu);
 
   // This configures an NSMenuItem with all the data from a BookmarkNode. This
   // is used to update existing menu items, as well as to configure newly
   // created ones, like in AddNodeToMenu().
-  void ConfigureMenuItem(const BookmarkNode* node, NSMenuItem* item);
+  // |set_title| is optional since it is only needed when we get a
+  // node changed notification.  On initial build of the menu we set
+  // the title as part of alloc/init.
+  void ConfigureMenuItem(const BookmarkNode* node, NSMenuItem* item,
+                         bool set_title);
 
   // Returns the NSMenuItem for a given BookmarkNode.
   NSMenuItem* MenuItemForNode(const BookmarkNode* node);
 
   // Return the Bookmark menu.
   virtual NSMenu* BookmarkMenu();
 
   // Start watching the bookmarks for changes.
   void ObserveBookmarkModel();
 
  private:
   friend class BookmarkMenuBridgeTest;
 
   Profile* profile_;  // weak
   BookmarkMenuCocoaController* controller_;  // strong
 
   // In order to appropriately update items in the bookmark menu, without
   // forcing a rebuild, map the model's nodes to menu items.
   std::map<const BookmarkNode*, NSMenuItem*> bookmark_nodes_;
 };
 
 #endif  // CHROME_BROWSER_COCOA_BOOKMARK_MENU_BRIDGE_H_