Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2450343003:
Milo: Pubsub pending build fixes. (Closed)
|
Created:
4 years, 1 month ago by Ryan Tseng Modified:
4 years, 1 month ago CC:
andrew.wang, chromium-reviews, infra-reviews+luci-go_chromium.org, M-A Ruel, tandrii+luci-go_chromium.org, todd Target Ref:
refs/heads/master Project:
luci-go Visibility:
Public. |
DescriptionMilo: Pubsub pending build fixes.
This fixes the large pending build (and master json size) issue by stripping out
all files, comments, and property information from pending builds (they aren't
used or displayed anywhere anyways.)
This shrunk chromium.fyi's compressed json size from 2MB down to 60KB
This also cleans up some debug statements.
BUG=654623
Committed: https://github.com/luci/luci-go/commit/b0a9fe11208861902c7767fbb3eb7adc98bff727
Patch Set 1 #Patch Set 2 : Cleanup #Patch Set 3 : fix #Messages
Total messages: 19 (15 generated)
The CQ bit was checked by hinoka@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by hinoka@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Luci-go Linux Trusty 64 Tester on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/321d56008cea9e10)
The CQ bit was checked by hinoka@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Luci-go Win Tester on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/321d5b5eb8ffa710)
Description was changed from ========== Milo: Pubsub pending build fixes. This fixes the large pending build (and master json size) issue by stripping out all files, comments, and property information from pending builds (they aren't used or displayed anywhere anyways.) This shrunk chromium.fyi's compressed json size from 2MB down to 60KB This also cleans up some debug statements. BUG= ========== to ========== Milo: Pubsub pending build fixes. This fixes the large pending build (and master json size) issue by stripping out all files, comments, and property information from pending builds (they aren't used or displayed anywhere anyways.) This shrunk chromium.fyi's compressed json size from 2MB down to 60KB This also cleans up some debug statements. BUG=654623 ==========
hinoka@chromium.org changed reviewers: + estaab@chromium.org
hinoka@chromium.org changed reviewers: + hinoka@chromium.org, martiniss@chromium.org
ptal, this was a result of a bunch of alerts firing due to fyi's master json size being too large due to the pending builds metadata.
lgtm
The CQ bit was checked by hinoka@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Milo: Pubsub pending build fixes. This fixes the large pending build (and master json size) issue by stripping out all files, comments, and property information from pending builds (they aren't used or displayed anywhere anyways.) This shrunk chromium.fyi's compressed json size from 2MB down to 60KB This also cleans up some debug statements. BUG=654623 ========== to ========== Milo: Pubsub pending build fixes. This fixes the large pending build (and master json size) issue by stripping out all files, comments, and property information from pending builds (they aren't used or displayed anywhere anyways.) This shrunk chromium.fyi's compressed json size from 2MB down to 60KB This also cleans up some debug statements. BUG=654623 Committed: https://github.com/luci/luci-go/commit/b0a9fe11208861902c7767fbb3eb7adc98bff727 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://github.com/luci/luci-go/commit/b0a9fe11208861902c7767fbb3eb7adc98bff727 |
