Show IDN in error screens (DNS failure etc.)

content/test/net/url_request_failed_job.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_TEST_NET_URL_REQUEST_FAILED_JOB_H_
 #define CONTENT_TEST_NET_URL_REQUEST_FAILED_JOB_H_
 
 #include <string>
 
 #include "base/compiler_specific.h"
 #include "base/memory/weak_ptr.h"
 #include "net/url_request/url_request_job.h"
 #include "url/gurl.h"
 
 namespace content {
 
 // This class simulates a URLRequestJob failing with a given error code while
 // trying to connect.
 class URLRequestFailedJob : public net::URLRequestJob {
  public:
   URLRequestFailedJob(net::URLRequest* request,
                       net::NetworkDelegate* network_delegate,
                       int net_error);
 
   virtual void Start() OVERRIDE;
 
   // Adds the testing URLs to the net::URLRequestFilter.
   static void AddUrlHandler();
+  static void AddUrlHandler(const std::string& hostname);

[mmenke, 2013/09/27 14:44:05]

Function overloading, while done a fair bit in Chrome, is generally discouraged.
 I suggest renaming to something like "AddUrlHandlerForHostname".

[yuusuke, 2013/09/28 10:42:50]

Done.

 
   // Given a net error code, constructs a mock URL that will return that error
   // asynchronously when started.  |net_error| must be a valid net error code
   // other than net::OK and net::ERR_IO_PENDING.
   static GURL GetMockHttpUrl(int net_error);
   static GURL GetMockHttpsUrl(int net_error);
+  static GURL GetMockHttpUrl(int net_error, const std::string& hostname);

[mmenke, 2013/09/27 14:44:05]

Suggest a comment above this line along the lines of "URLRequestFailedJob must
be added as a handler for |hostname| for the returned URL to return
|net_error|."

[yuusuke, 2013/09/28 10:42:50]

Done.

+  static GURL GetMockHttpsUrl(int net_error, const std::string& hostname);

[mmenke, 2013/09/27 14:44:05]

Again, suggest adding a "ForHostname" to the end of these two.  Think it also
makes code a little clearer, despite the fact it just duplicates an argument
name.

[yuusuke, 2013/09/28 10:42:50]

Done.

 
  private:
   static net::URLRequestJob* Factory(net::URLRequest* request,
                                      net::NetworkDelegate* network_delegate,
                                      const std::string& scheme);
 
   virtual ~URLRequestFailedJob();
 
   // Simulate a failure.
   void StartAsync();
 
   const int net_error_;
 
   base::WeakPtrFactory<URLRequestFailedJob> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(URLRequestFailedJob);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_TEST_NET_URL_REQUEST_FAILED_JOB_H_