Issue 24503003: SampleApp - reduce unnecessary verbosity

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24503003: SampleApp - reduce unnecessary verbosity (Closed)

Created:
7 years, 2 months ago by hal.canary

Modified:
7 years, 2 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

SampleApp - reduce unnecessary verbosity [with --picture $path] Before this change, `SampleApp --picture $path` prints out usage (as well as --pictureDir) as if there was a syntax error in the command line arguments. BUG=skia:1677 R=reed@google.com Committed: https://code.google.com/p/skia/source/detail?r=11748

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : description #

Patch Set 4 : lint comment change #

Patch Set 5 : rebased again #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	samplecode/SampleApp.cpp	View	1 2 3	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

hal.canary

Mike, it looks like you last touched the "--pictureDir" syntax, so I'll let you look ...

7 years, 2 months ago (2013-09-25 14:05:41 UTC) #1

hal.canary

7 years, 2 months ago (2013-10-14 12:47:42 UTC) #3

Message was sent while issue was closed.

Committed patchset #5 manually as r11748 (presubmit successful).

Expand Messages | Collapse Messages