Issue 2450283003: Try to load the existing unlinked bundle by the content hash.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2450283003: Try to load the existing unlinked bundle by the content hash. (Closed)

Created:
4 years, 1 month ago by scheglov

Modified:
4 years, 1 month ago

Reviewers:
Paul Berry, Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Try to load the existing unlinked bundle by the content hash. So that we don't create _File.forResolution() when we could use only the content hash and the existing unlinked bundle. This makes loading cached analysis results cheaper - no need to parse the unit. TBR R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/6be23afcf2714dc478646c12d6f5a88dff095f3e

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+88 lines, -69 lines)			Patch
	M	pkg/analyzer/lib/src/dart/analysis/driver.dart	View		9 chunks	+88 lines, -69 lines	0 comments	Download

Total messages: 5 (1 generated)

scheglov

Committed patchset #1 (id:1) manually as 6be23afcf2714dc478646c12d6f5a88dff095f3e (presubmit successful).

4 years, 1 month ago (2016-10-26 20:06:09 UTC) #3

Message was sent while issue was closed.

lgtm