Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2450253002: Improve exception printing for debug (Closed)

Created:
4 years, 1 month ago by Clemens Hammacher
Modified:
4 years, 1 month ago
Reviewers:
titzer, ahaas
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Improve exception printing for debug If there is no stack trace (which happens), then at least print the location of the message. R=titzer@chromium.org,ahaas@chromium.org Committed: https://crrev.com/ff5194e3ce9cabda5af4c22e024202c623e30b92 Cr-Commit-Position: refs/heads/master@{#40599}

Patch Set 1 #

Patch Set 2 : Fix for non-debug builds #

Total comments: 2

Patch Set 3 : Address commends #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M src/isolate.cc View 1 2 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
Clemens Hammacher
4 years, 1 month ago (2016-10-26 15:37:11 UTC) #9
titzer
lgtm https://codereview.chromium.org/2450253002/diff/20001/src/isolate.cc File src/isolate.cc (right): https://codereview.chromium.org/2450253002/diff/20001/src/isolate.cc#newcode1084 src/isolate.cc:1084: if (AllowHeapAllocation::IsAllowed()) { Maybe add a comment that ...
4 years, 1 month ago (2016-10-26 15:52:47 UTC) #10
Clemens Hammacher
https://codereview.chromium.org/2450253002/diff/20001/src/isolate.cc File src/isolate.cc (right): https://codereview.chromium.org/2450253002/diff/20001/src/isolate.cc#newcode1084 src/isolate.cc:1084: if (AllowHeapAllocation::IsAllowed()) { On 2016/10/26 15:52:47, titzer wrote: > ...
4 years, 1 month ago (2016-10-26 16:15:41 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2450253002/40001
4 years, 1 month ago (2016-10-26 16:15:51 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-10-26 16:45:20 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:14:28 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ff5194e3ce9cabda5af4c22e024202c623e30b92
Cr-Commit-Position: refs/heads/master@{#40599}

Powered by Google App Engine
This is Rietveld 408576698