[ignition] Add a property call bytecode

src/interpreter/bytecode-array-builder.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/interpreter/bytecode-array-builder.h"
 
 #include "src/globals.h"
 #include "src/interpreter/bytecode-array-writer.h"
 #include "src/interpreter/bytecode-dead-code-optimizer.h"
 #include "src/interpreter/bytecode-label.h"
@@ skipping 806 matching lines @@
 BytecodeArrayBuilder& BytecodeArrayBuilder::MarkTryEnd(int handler_id) {
   BytecodeLabel try_end;
   Bind(&try_end);
   handler_table_builder()->SetTryRegionEnd(handler_id, try_end.offset());
   return *this;
 }
 
 BytecodeArrayBuilder& BytecodeArrayBuilder::Call(Register callable,
                                                  RegisterList args,
                                                  int feedback_slot,
-                                                 TailCallMode tail_call_mode) {
+                                                 TailCallMode tail_call_mode,
+                                                 Call::CallType call_type) {
   if (tail_call_mode == TailCallMode::kDisallow) {
-    OutputCall(callable, args, args.register_count(), feedback_slot);
+    if (call_type == Call::NAMED_PROPERTY_CALL ||
+        call_type == Call::KEYED_PROPERTY_CALL) {
+      OutputCallProperty(callable, args, args.register_count(), feedback_slot);
+    } else {
+      OutputCall(callable, args, args.register_count(), feedback_slot);
+    }
   } else {
     DCHECK(tail_call_mode == TailCallMode::kAllow);

[rmcilroy, 2016/10/26 16:20:16]

We should we do this for tail-calls too? Michi - any idea what is the status of
shipping TCO is?

[Michael Starzinger, 2016/10/26 18:03:01]

It is currently staged as an experimental feature. Shipping plans are unclear. I
don't have strong opinions about whether to add a "TailCallProperty" bytecode or
not, either way is fine with me.

[Leszek Swirski, 2016/10/27 09:08:24]

I left it as-is to not have to introduce another bytecode -- I'd be surprised if
we often had tail-calls for property calls, but I may be proven wrong by, e.g.,
callback style programming

     OutputTailCall(callable, args, args.register_count(), feedback_slot);
   }
   return *this;
 }
 
 BytecodeArrayBuilder& BytecodeArrayBuilder::New(Register constructor,
                                                 RegisterList args,
                                                 int feedback_slot_id) {
   OutputNew(constructor, args, args.register_count(), feedback_slot_id);
   return *this;
@@ skipping 137 matching lines @@
     RegisterList reg_list) {
   DCHECK(RegisterListIsValid(reg_list));
   if (register_optimizer_)
     register_optimizer_->PrepareOutputRegisterList(reg_list);
   return static_cast<uint32_t>(reg_list.first_register().ToOperand());
 }
 
 }  // namespace interpreter
 }  // namespace internal
 }  // namespace v8