Refactor PathTest.cpp test_isNestedRects and test_isRect.

Refactor PathTest.cpp test_isNestedRects and test_isRect.

The existing implementations make it difficult to add new tests
and rely on non-local side effects.

R=bsalomon@google.com

Committed: https://code.google.com/p/skia/source/detail?r=11455

[bsalomon, 2013-09-25 18:10:23]

lgtm with some style nits noted below

https://codereview.chromium.org/24502004/diff/1/tests/PathTest.cpp
File tests/PathTest.cpp (right):

https://codereview.chromium.org/24502004/diff/1/tests/PathTest.cpp#newcode1309
tests/PathTest.cpp:1309: SkPoint *points;
fPoints,
...

https://codereview.chromium.org/24502004/diff/1/tests/PathTest.cpp#newcode1357
tests/PathTest.cpp:1357: REPORTER_ASSERT(reporter, (!tests[testIndex].isRect) ^
path.isRect(NULL));
Feel free to ignore but I'd find this easier to read as "tests[testIndex].isRect
== path.isRect(NULL)"

[bungeman-skia, 2013-09-25 18:21:11]

https://codereview.chromium.org/24502004/diff/1/tests/PathTest.cpp
File tests/PathTest.cpp (right):

https://codereview.chromium.org/24502004/diff/1/tests/PathTest.cpp#newcode1309
tests/PathTest.cpp:1309: SkPoint *points;
On 2013/09/25 18:10:23, bsalomon wrote:
> fPoints,
> ...

Done.

https://codereview.chromium.org/24502004/diff/1/tests/PathTest.cpp#newcode1357
tests/PathTest.cpp:1357: REPORTER_ASSERT(reporter, (!tests[testIndex].isRect) ^
path.isRect(NULL));
On 2013/09/25 18:10:23, bsalomon wrote:
> Feel free to ignore but I'd find this easier to read as
"tests[testIndex].isRect
> == path.isRect(NULL)"

Done.

[bungeman-skia, 2013-09-25 18:21:42]

Committed patchset #3 manually as r11455.