Issue 2450183004: More tests and a few fixed for the driver.

Issue 2450183004: More tests and a few fixed for the driver. (Closed)

Created:
4 years, 1 month ago by scheglov

Modified:
4 years, 1 month ago

Reviewers:
Paul Berry, Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

More tests and a few fixed for the driver. TBR R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/2625d6af374b450f1fd923fcf7767572dfe3e457

Patch Set 1 #

Total comments: 1

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+360 lines, -8 lines)			Patch
	M	pkg/analyzer/lib/src/dart/analysis/driver.dart	View		6 chunks	+16 lines, -3 lines	0 comments	Download
	M	pkg/analyzer/test/src/dart/analysis/driver_test.dart	View		7 chunks	+344 lines, -5 lines	1 comment	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

scheglov

Committed patchset #1 (id:1) manually as 2625d6af374b450f1fd923fcf7767572dfe3e457 (presubmit successful).

4 years, 1 month ago (2016-10-27 17:52:18 UTC) #3

Brian Wilkerson

lgtm https://codereview.chromium.org/2450183004/diff/1/pkg/analyzer/test/src/dart/analysis/driver_test.dart File pkg/analyzer/test/src/dart/analysis/driver_test.dart (right): https://codereview.chromium.org/2450183004/diff/1/pkg/analyzer/test/src/dart/analysis/driver_test.dart#newcode302 pkg/analyzer/test/src/dart/analysis/driver_test.dart:302: // Update "a" that that "A1" is now ...

4 years, 1 month ago (2016-10-27 20:08:17 UTC) #4

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages