Add columns to gtk task manager....

Add columns to gtk task manager.

BUG=16221
TEST=Open task man, right-click dialog, enable new columns (image size, script size, css size), surf around.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27394

[jamesr, 2009-09-26 00:59:54]

http://codereview.chromium.org/245018/diff/1/2
File chrome/browser/gtk/task_manager_gtk.cc (right):

http://codereview.chromium.org/245018/diff/1/2#newcode52
Line 52: kTaskManagerWebcoreImageCache,
WebCore would be more consistent

http://codereview.chromium.org/245018/diff/1/2#newcode599
Line 599: row, IDS_TASK_MANAGER_WEBCORE_IMAGE_CACHE_COLUMN);
It looks like this will always query the model even when the columns are hidden,
which is somewhat unfortunate because the WebCore*CacheSize() rows auto-update
themselves via IPC when queried.  Would it make sense to only populate these
fields when the columns are set to visible?

[Nico, 2009-09-26 01:14:07]

I observed that %cpu goes to 100% on gmail when one of these three columns is
open, while it's 1% when they're all closed. Is that the case on the other
platforms too? (OS X doesn't count, as it doesn't measure %cpu correclty atm)

http://codereview.chromium.org/245018/diff/1/2
File chrome/browser/gtk/task_manager_gtk.cc (right):

http://codereview.chromium.org/245018/diff/1/2#newcode52
Line 52: kTaskManagerWebcoreImageCache,
On 2009/09/26 00:59:54, jamesr wrote:
> WebCore would be more consistent

That's what I thought, but I tried to be consistent with
IDS_TASK_MANAGER_WEBCORE… (which isn't called …WEB_CORE…).

Done anyway.

http://codereview.chromium.org/245018/diff/1/2#newcode599
Line 599: row, IDS_TASK_MANAGER_WEBCORE_IMAGE_CACHE_COLUMN);
On 2009/09/26 00:59:54, jamesr wrote:
> It looks like this will always query the model even when the columns are
hidden,
> which is somewhat unfortunate because the WebCore*CacheSize() rows auto-update
> themselves via IPC when queried.  Would it make sense to only populate these
> fields when the columns are set to visible?

Good catch! Done.

[Nico, 2009-09-26 01:24:36]

Looks like the %cpu stuff was just coincidence, I can't repro it any more.

[James Hawkins, 2009-09-28 18:37:04]

LGTM