Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 2450163002: Print Preview: Handle printer media without name fields. (Closed)

Created:
4 years, 1 month ago by Lei Zhang
Modified:
4 years, 1 month ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Print Preview: Handle printer media without name fields. BUG=659003 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/6dc2dbbd01010135633d1d0cfafda11a12aabf73 Cr-Commit-Position: refs/heads/master@{#427871}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/print_preview/data/destination_store.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
Lei Zhang
4 years, 1 month ago (2016-10-26 05:37:13 UTC) #4
Lei Zhang
4 years, 1 month ago (2016-10-26 21:17:52 UTC) #9
dpapad
lgtm
4 years, 1 month ago (2016-10-26 23:11:52 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2450163002/1
4 years, 1 month ago (2016-10-26 23:13:46 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-26 23:20:43 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 23:25:26 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6dc2dbbd01010135633d1d0cfafda11a12aabf73
Cr-Commit-Position: refs/heads/master@{#427871}

Powered by Google App Engine
This is Rietveld 408576698