Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 2450133003: Convert relative paths to absolute paths in iOS test runner (Closed)

Created:
4 years, 1 month ago by smut
Modified:
4 years, 1 month ago
Reviewers:
huangml1, huangml
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert relative paths to absolute paths in iOS test runner xctests for devices require BUILT_PRODUCTS_DIR to be an absolute path. Might as well just make all paths absolute. n.b. Inputs to the test runner are always relative paths because this is required by Swarming. BUG=608537 TBR=huangml Committed: https://crrev.com/22203b32bdae9236d23cc89e70772721315f2d1f Cr-Commit-Position: refs/heads/master@{#427892}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M ios/build/bots/scripts/test_runner.py View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
smut
4 years, 1 month ago (2016-10-27 00:28:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2450133003/1
4 years, 1 month ago (2016-10-27 00:29:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-27 00:43:25 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/22203b32bdae9236d23cc89e70772721315f2d1f Cr-Commit-Position: refs/heads/master@{#427892}
4 years, 1 month ago (2016-10-27 00:45:07 UTC) #9
huangml1
4 years, 1 month ago (2016-10-27 19:17:33 UTC) #11
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698