Issue 245013002: Fix for help-app article link on OOBE reset screen.

Issue 245013002: Fix for help-app article link on OOBE reset screen. (Closed)

Created:
6 years, 8 months ago by merkulova

Modified:
6 years, 7 months ago

Reviewers:
dzhioev (left Google), Nikita (slow)

CC:
chromium-reviews, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix for help-app article link on OOBE reset screen. BUG=297874 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265905 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266815

Patch Set 1 #

Patch Set 2 : Fix #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	chrome/browser/resources/chromeos/login/oobe_screen_reset.js	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 20 (0 generated)

Expand Messages | Collapse Messages

dzhioev (left Google)

On 2014/04/21 09:39:53, merkulova wrote: LGTM

6 years, 8 months ago (2014-04-22 08:21:39 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/merkulova@chromium.org/245013002/1

6 years, 8 months ago (2014-04-22 08:24:18 UTC) #4

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

6 years, 8 months ago (2014-04-22 09:06:27 UTC) #5

commit-bot: I haz the power

Try jobs failed on following builders: tryserver.chromium on chromium_presubmit

6 years, 8 months ago (2014-04-22 09:06:31 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/merkulova@chromium.org/245013002/1

6 years, 8 months ago (2014-04-24 11:27:16 UTC) #8

bshe

On 2014/04/24 11:29:46, I haz the power (commit-bot) wrote: > Change committed as 265905 It ...

6 years, 8 months ago (2014-04-24 14:47:16 UTC) #10

Message was sent while issue was closed.

On 2014/04/24 11:29:46, I haz the power (commit-bot) wrote:
> Change committed as 265905

It looks like this CL is causing linux_chromiumos bots failure. The call stack
is something like this:

[21090:21090:0424/055814:ERROR:CONSOLE(3116)] "Uncaught SyntaxError: Unexpected
identifier", source: chrome://oobe/login.js (3116)
[21090:21109:0424/055840:ERROR:cpu_data_collector.cc(215)] CPU freq stats not
available in sysfs.
BrowserTestBase signal handler received SIGTERM. Backtrace:
#0 0x7fc45961c121 base::debug::StackTrace::StackTrace()
#1 0x000003c120de content::(anonymous namespace)::DumpStackTraceSignalHandler()
#2 0x7fc445c3f4a0 <unknown>
#3 0x7fc445cf1a43 __poll
#4 0x7fc44595aff6 <unknown>
#5 0x7fc44595b124 g_main_context_iteration
#6 0x7fc4595e310c base::MessagePumpGlib::Run()
#7 0x7fc4596b5fff base::MessageLoop::RunHandler()
#8 0x7fc459711198 base::RunLoop::Run()
#9 0x000003c28641 content::RunThisRunLoop()
#10 0x000003c28a9e content::MessageLoopRunner::Run()
#11 0x000003c28f2b content::WindowedNotificationObserver::Wait()
#12 0x000000d7467a chromeos::ScreenLockerTest::LockScreen()
#13 0x000000d738b2
chromeos::ScreenLockerTest_TestShowTwice_Test::RunTestOnMainThread()
#14 0x000001db88aa InProcessBrowserTest::RunTestOnMainThreadLoop()
#15 0x000003c12d45 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
#16 0x000003c1390e base::internal::RunnableAdapter<>::Run()
#17 0x000003c1385a base::internal::InvokeHelper<>::MakeItSo()
#18 0x000003c13775 base::internal::Invoker<>::Run()
#19 0x000000bc5b63 base::Callback<>::Run()
#20 0x000003cf4182 ChromeBrowserMainParts::PreMainMessageLoopRunImpl()
#21 0x000003cf253a ChromeBrowserMainParts::PreMainMessageLoopRun()
#22 0x0000034165b9
chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun()
#23 0x7fc44a87df30 content::BrowserMainLoop::PreMainMessageLoopRun()
#24 0x7fc44a8857be base::internal::RunnableAdapter<>::Run()
#25 0x7fc44a885384 base::internal::InvokeHelper<>::MakeItSo()
#26 0x7fc44a884cf1 base::internal::Invoker<>::Run()
#27 0x7fc44ac9053d base::Callback<>::Run()
#28 0x7fc44af98976 content::StartupTaskRunner::RunAllTasksNow()
#29 0x7fc44a87d646 content::BrowserMainLoop::CreateStartupTasks()
#30 0x7fc44a88632a content::BrowserMainRunnerImpl::Initialize()
#31 0x7fc44a879e8b content::BrowserMain()
#32 0x7fc44a813fc8 content::RunNamedProcessTypeMain()
#33 0x7fc44a8152c5 content::ContentMainRunnerImpl::Run()
#34 0x7fc44a8134df content::ContentMain()
#35 0x000003c12cac content::BrowserTestBase::SetUp()
#36 0x000001db7a32 InProcessBrowserTest::SetUp()
#37 0x000000defcc2 testing::internal::HandleSehExceptionsInMethodIfSupported<>()
#38 0x000000deba0f testing::internal::HandleExceptionsInMethodIfSupported<>()
#39 0x000000ddffdf testing::Test::Run()
#40 0x000000de065a testing::TestInfo::Run()
#41 0x000000de0bb5 testing::TestCase::Run()
#42 0x000000de5627 testing::internal::UnitTestImpl::RunAllTests()
#43 0x000000df0ed5 testing::internal::HandleSehExceptionsInMethodIfSupported<>()
#44 0x000000dec8ef testing::internal::HandleExceptionsInMethodIfSupported<>()
#45 0x000000de4615 testing::UnitTest::Run()
#46 0x000001de0cab RUN_ALL_TESTS()
#47 0x000001de07c4 base::TestSuite::Run()
#48 0x000000d46f73 InteractiveUITestSuiteRunner::RunTestSuite()
#49 0x000001db5e16 (anonymous
namespace)::ChromeTestLauncherDelegate::RunTestSuite()
#50 0x000003c241eb content::LaunchTests()
#51 0x000001db615d LaunchChromeTests()
#52 0x000000d46e67 main
#53 0x7fc445c2a76d __libc_start_main
#54 0x000000ba5f49 <unknown>

merkulova

On 2014/04/24 14:47:16, bshe wrote: > On 2014/04/24 11:29:46, I haz the power (commit-bot) wrote: ...

6 years, 8 months ago (2014-04-24 14:53:25 UTC) #11

Message was sent while issue was closed.

On 2014/04/24 14:47:16, bshe wrote:
> On 2014/04/24 11:29:46, I haz the power (commit-bot) wrote:
> > Change committed as 265905
> 
> It looks like this CL is causing linux_chromiumos bots failure. The call stack
> is something like this:
> 
> [21090:21090:0424/055814:ERROR:CONSOLE(3116)] "Uncaught SyntaxError:
Unexpected
> identifier", source: chrome://oobe/login.js (3116)
> [21090:21109:0424/055840:ERROR:cpu_data_collector.cc(215)] CPU freq stats not
> available in sysfs.
> BrowserTestBase signal handler received SIGTERM. Backtrace:
> #0 0x7fc45961c121 base::debug::StackTrace::StackTrace()
> #1 0x000003c120de content::(anonymous
namespace)::DumpStackTraceSignalHandler()
> #2 0x7fc445c3f4a0 <unknown>
> #3 0x7fc445cf1a43 __poll
> #4 0x7fc44595aff6 <unknown>
> #5 0x7fc44595b124 g_main_context_iteration
> #6 0x7fc4595e310c base::MessagePumpGlib::Run()
> #7 0x7fc4596b5fff base::MessageLoop::RunHandler()
> #8 0x7fc459711198 base::RunLoop::Run()
> #9 0x000003c28641 content::RunThisRunLoop()
> #10 0x000003c28a9e content::MessageLoopRunner::Run()
> #11 0x000003c28f2b content::WindowedNotificationObserver::Wait()
> #12 0x000000d7467a chromeos::ScreenLockerTest::LockScreen()
> #13 0x000000d738b2
> chromeos::ScreenLockerTest_TestShowTwice_Test::RunTestOnMainThread()
> #14 0x000001db88aa InProcessBrowserTest::RunTestOnMainThreadLoop()
> #15 0x000003c12d45 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
> #16 0x000003c1390e base::internal::RunnableAdapter<>::Run()
> #17 0x000003c1385a base::internal::InvokeHelper<>::MakeItSo()
> #18 0x000003c13775 base::internal::Invoker<>::Run()
> #19 0x000000bc5b63 base::Callback<>::Run()
> #20 0x000003cf4182 ChromeBrowserMainParts::PreMainMessageLoopRunImpl()
> #21 0x000003cf253a ChromeBrowserMainParts::PreMainMessageLoopRun()
> #22 0x0000034165b9
> chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun()
> #23 0x7fc44a87df30 content::BrowserMainLoop::PreMainMessageLoopRun()
> #24 0x7fc44a8857be base::internal::RunnableAdapter<>::Run()
> #25 0x7fc44a885384 base::internal::InvokeHelper<>::MakeItSo()
> #26 0x7fc44a884cf1 base::internal::Invoker<>::Run()
> #27 0x7fc44ac9053d base::Callback<>::Run()
> #28 0x7fc44af98976 content::StartupTaskRunner::RunAllTasksNow()
> #29 0x7fc44a87d646 content::BrowserMainLoop::CreateStartupTasks()
> #30 0x7fc44a88632a content::BrowserMainRunnerImpl::Initialize()
> #31 0x7fc44a879e8b content::BrowserMain()
> #32 0x7fc44a813fc8 content::RunNamedProcessTypeMain()
> #33 0x7fc44a8152c5 content::ContentMainRunnerImpl::Run()
> #34 0x7fc44a8134df content::ContentMain()
> #35 0x000003c12cac content::BrowserTestBase::SetUp()
> #36 0x000001db7a32 InProcessBrowserTest::SetUp()
> #37 0x000000defcc2
testing::internal::HandleSehExceptionsInMethodIfSupported<>()
> #38 0x000000deba0f testing::internal::HandleExceptionsInMethodIfSupported<>()
> #39 0x000000ddffdf testing::Test::Run()
> #40 0x000000de065a testing::TestInfo::Run()
> #41 0x000000de0bb5 testing::TestCase::Run()
> #42 0x000000de5627 testing::internal::UnitTestImpl::RunAllTests()
> #43 0x000000df0ed5
testing::internal::HandleSehExceptionsInMethodIfSupported<>()
> #44 0x000000dec8ef testing::internal::HandleExceptionsInMethodIfSupported<>()
> #45 0x000000de4615 testing::UnitTest::Run()
> #46 0x000001de0cab RUN_ALL_TESTS()
> #47 0x000001de07c4 base::TestSuite::Run()
> #48 0x000000d46f73 InteractiveUITestSuiteRunner::RunTestSuite()
> #49 0x000001db5e16 (anonymous
> namespace)::ChromeTestLauncherDelegate::RunTestSuite()
> #50 0x000003c241eb content::LaunchTests()
> #51 0x000001db615d LaunchChromeTests()
> #52 0x000000d46e67 main
> #53 0x7fc445c2a76d __libc_start_main
> #54 0x000000ba5f49 <unknown>

Reverted https://codereview.chromium.org/251373008/

dzhioev (left Google)

On 2014/04/25 10:29:46, Nikita Kostylev wrote: > lgtm LGTM, but this review is closed already. ...

6 years, 8 months ago (2014-04-25 10:58:26 UTC) #14

Nikita (slow)

This one could be reopened. I suggest reusing existing CLs in such cases. To unsubscribe ...

6 years, 8 months ago (2014-04-25 11:02:45 UTC) #15

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/merkulova@chromium.org/245013002/20001

6 years, 7 months ago (2014-04-29 09:53:24 UTC) #19

Message was sent while issue was closed.

Change committed as 266815

Expand Messages | Collapse Messages