[Payments] Increase spacing for payment request credit card and address editors

Increase spacing for payment request credit card and address editors

This CL also adds cards icon border and changes the cardEditor title.

BUG=657178, 657952
Committed: https://crrev.com/6d062f24e1ede7485051d12eea9909f24c453362
Cr-Commit-Position: refs/heads/master@{#428247}

[gogerald1, 2016-10-26 22:34:44]

Description was changed from

==========
increase spacing for text fields and dropdowns in paymentrequest credit card and
address editors

BUG=
==========

to

==========
Increase spacing for payment request credit card and address editors

This CL also adds cards icon border.

BUG=657178, 657952
==========

[gogerald1, 2016-10-27 18:11:55]

Patchset #1 (id:1) has been deleted

[gogerald1, 2016-10-27 18:12:01]

Patchset #1 (id:20001) has been deleted

[gogerald1, 2016-10-27 18:12:07]

Patchset #1 (id:40001) has been deleted

[gogerald1, 2016-10-27 18:12:35]

Description was changed from

==========
Increase spacing for payment request credit card and address editors

This CL also adds cards icon border.

BUG=657178, 657952
==========

to

==========
Increase spacing for payment request credit card and address editors

This CL also adds cards icon border and changes the cardEditor title.

BUG=657178, 657952
==========

[gogerald1, 2016-10-27 18:12:44]

The CQ bit was checked by gogerald@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 18:13:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gogerald1, 2016-10-27 18:15:37]

gogerald@chromium.org changed reviewers:
+ dfalcantara@chromium.org, rouslan@chromium.org

[gogerald1, 2016-10-27 18:15:38]

Hi, PTAL,

[commit-bot: I haz the power, 2016-10-27 18:17:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 18:17:06]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[please use gerrit instead, 2016-10-27 18:17:41]

lgtm

[gogerald1, 2016-10-27 18:30:39]

The CQ bit was checked by gogerald@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 18:31:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 19:10:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 19:10:35]

Dry run: This issue passed the CQ dry run.

[gone, 2016-10-27 22:58:13]

lgtm

https://codereview.chromium.org/2450113003/diff/80001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorIconsField.java
(right):

https://codereview.chromium.org/2450113003/diff/80001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorIconsField.java:46:
layoutParams, context.getResources().getDimensionPixelSize(
Pull this getDimensionPixelSize call out and move it above with the other one.

[gogerald1, 2016-10-28 00:14:22]

https://codereview.chromium.org/2450113003/diff/80001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorIconsField.java
(right):

https://codereview.chromium.org/2450113003/diff/80001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorIconsField.java:46:
layoutParams, context.getResources().getDimensionPixelSize(
On 2016/10/27 22:58:13, dfalcantara (slow 10.24) wrote:
> Pull this getDimensionPixelSize call out and move it above with the other one.

Why pull it out? -_-, the value only be used here for one time, looks efficient
and readable to leave it here.

[gone, 2016-10-28 00:21:48]

https://codereview.chromium.org/2450113003/diff/80001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorIconsField.java
(right):

https://codereview.chromium.org/2450113003/diff/80001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorIconsField.java:46:
layoutParams, context.getResources().getDimensionPixelSize(
On 2016/10/28 00:14:22, gogerald1 wrote:
> On 2016/10/27 22:58:13, dfalcantara (slow 10.24) wrote:
> > Pull this getDimensionPixelSize call out and move it above with the other
one.
> 
> Why pull it out? -_-, the value only be used here for one time, looks
efficient
> and readable to leave it here.

Because the indentation is terrible.

[gogerald1, 2016-10-28 00:47:17]

The CQ bit was checked by gogerald@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-28 00:47:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gogerald1, 2016-10-28 00:52:35]

https://codereview.chromium.org/2450113003/diff/80001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorIconsField.java
(right):

https://codereview.chromium.org/2450113003/diff/80001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorIconsField.java:46:
layoutParams, context.getResources().getDimensionPixelSize(
On 2016/10/28 00:21:48, dfalcantara (slow 10.24) wrote:
> On 2016/10/28 00:14:22, gogerald1 wrote:
> > On 2016/10/27 22:58:13, dfalcantara (slow 10.24) wrote:
> > > Pull this getDimensionPixelSize call out and move it above with the other
> one.
> > 
> > Why pull it out? -_-, the value only be used here for one time, looks
> efficient
> > and readable to leave it here.
> 
> Because the indentation is terrible.

Done.

[commit-bot: I haz the power, 2016-10-28 01:23:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 01:23:49]

Dry run: This issue passed the CQ dry run.

[gogerald1, 2016-10-28 01:31:46]

The CQ bit was checked by gogerald@chromium.org

[gogerald1, 2016-10-28 01:31:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
rouslan@chromium.org, dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2450113003/#ps100001
(title: "for better indentation")

[commit-bot: I haz the power, 2016-10-28 01:32:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 02:17:36]

Description was changed from

==========
Increase spacing for payment request credit card and address editors

This CL also adds cards icon border and changes the cardEditor title.

BUG=657178, 657952
==========

to

==========
Increase spacing for payment request credit card and address editors

This CL also adds cards icon border and changes the cardEditor title.

BUG=657178, 657952
==========

[commit-bot: I haz the power, 2016-10-28 02:17:39]

Committed patchset #3 (id:100001)

[commit-bot: I haz the power, 2016-10-28 02:21:40]

Description was changed from

==========
Increase spacing for payment request credit card and address editors

This CL also adds cards icon border and changes the cardEditor title.

BUG=657178, 657952
==========

to

==========
Increase spacing for payment request credit card and address editors

This CL also adds cards icon border and changes the cardEditor title.

BUG=657178, 657952

Committed: https://crrev.com/6d062f24e1ede7485051d12eea9909f24c453362
Cr-Commit-Position: refs/heads/master@{#428247}
==========

[commit-bot: I haz the power, 2016-10-28 02:21:41]

Patchset 3 (id:??) landed as
https://crrev.com/6d062f24e1ede7485051d12eea9909f24c453362
Cr-Commit-Position: refs/heads/master@{#428247}