Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 2450093007: X87: [crankshaft] Support all oddballs for truncating TaggedToI changes. (Closed)

Created:
4 years, 1 month ago by zhengxing.li
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [crankshaft] Support all oddballs for truncating TaggedToI changes. port 7d383be9da728997e0c0a68500a6ac2f248240c1 (r40608) original commit message: For inputs to truncating binary operations like <<, | or >>>, support all Oddballs not just undefined, true and false. This unifies treatment of these truncations in Crankshaft and TurboFan, and is very easy nowadays, since the memory layout of Oddball and HeapNumber is compatible. BUG= Committed: https://crrev.com/77ae68846b03e37df377c0700b674e1051fc8136 Cr-Commit-Position: refs/heads/master@{#40632}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -25 lines) Patch
M src/crankshaft/x87/lithium-codegen-x87.cc View 1 chunk +9 lines, -25 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 1 month ago (2016-10-27 10:18:30 UTC) #2
Weiliang
lgtm
4 years, 1 month ago (2016-10-27 13:53:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2450093007/1
4 years, 1 month ago (2016-10-28 01:35:33 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-28 02:03:16 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:16:06 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/77ae68846b03e37df377c0700b674e1051fc8136
Cr-Commit-Position: refs/heads/master@{#40632}

Powered by Google App Engine
This is Rietveld 408576698