GetCurrentMemoryState() shouldn't return SUSPENDED state in browser

GetCurrentMemoryState() shouldn't return SUSPENDED state in browser

At least for now, clients in the browser process don't accept
SUSPENDED state. MemoryCoordinatorImpl::GetCurrentMemoryState()
shouldn't return SUSPENDED state. Use THROTTLED state instead.

BUG=659891
Committed: https://crrev.com/0693b4df2baa450f88e4dbefc65a30bafc66e769
Cr-Commit-Position: refs/heads/master@{#427980}

[bashi, 2016-10-27 05:30:37]

The CQ bit was checked by bashi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 05:30:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bashi, 2016-10-27 05:31:44]

bashi@chromium.org changed reviewers:
+ chrisha@chromium.org, hajimehoshi@chromium.org, haraken@chromium.org

[bashi, 2016-10-27 05:31:45]

PTAL

[haraken, 2016-10-27 05:33:57]

LGTM

[hajimehoshi, 2016-10-27 05:38:58]

https://codereview.chromium.org/2450093006/diff/1/content/browser/memory/memo...
File content/browser/memory/memory_coordinator_impl.cc (right):

https://codereview.chromium.org/2450093006/diff/1/content/browser/memory/memo...
content/browser/memory/memory_coordinator_impl.cc:118: : current_state_;
UNKNOWN is also not permitted. How about adding DCHECK(current_state_ !=
MemoryState::UNKNOWN) to this getter and setter?

[hajimehoshi, 2016-10-27 05:39:39]

https://codereview.chromium.org/2450093006/diff/1/content/browser/memory/memo...
File content/browser/memory/memory_coordinator_impl.cc (right):

https://codereview.chromium.org/2450093006/diff/1/content/browser/memory/memo...
content/browser/memory/memory_coordinator_impl.cc:118: : current_state_;
On 2016/10/27 05:38:57, hajimehoshi wrote:
> UNKNOWN is also not permitted. How about adding DCHECK(current_state_ !=
> MemoryState::UNKNOWN) to this getter and setter?

Oops, this DECHECK should not be in the setter since it's legal for renderer
processes.

[bashi, 2016-10-27 05:45:24]

https://codereview.chromium.org/2450093006/diff/1/content/browser/memory/memo...
File content/browser/memory/memory_coordinator_impl.cc (right):

https://codereview.chromium.org/2450093006/diff/1/content/browser/memory/memo...
content/browser/memory/memory_coordinator_impl.cc:118: : current_state_;
On 2016/10/27 05:39:39, hajimehoshi wrote:
> On 2016/10/27 05:38:57, hajimehoshi wrote:
> > UNKNOWN is also not permitted. How about adding DCHECK(current_state_ !=
> > MemoryState::UNKNOWN) to this getter and setter?
> 
> Oops, this DECHECK should not be in the setter since it's legal for renderer
> processes.

Done. I think adding DCHECK(!UNKNOWN) to setter is enough as the default state
is NORMAL.

[bashi, 2016-10-27 05:45:34]

The CQ bit was checked by bashi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 05:45:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hajimehoshi, 2016-10-27 05:51:08]

lgtm

[commit-bot: I haz the power, 2016-10-27 07:00:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 07:00:17]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[bashi, 2016-10-27 08:03:51]

The CQ bit was checked by bashi@chromium.org

[bashi, 2016-10-27 08:03:51]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2450093006/#ps20001
(title: "DCHECK for UNKNOWN")

[commit-bot: I haz the power, 2016-10-27 08:04:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 09:40:54]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-27 09:42:24]

Description was changed from

==========
GetCurrentMemoryState() shouldn't return SUSPENDED state in browser

At least for now, clients in the browser process don't accept
SUSPENDED state. MemoryCoordinatorImpl::GetCurrentMemoryState()
shouldn't return SUSPENDED state. Use THROTTLED state instead.

BUG=659891
==========

to

==========
GetCurrentMemoryState() shouldn't return SUSPENDED state in browser

At least for now, clients in the browser process don't accept
SUSPENDED state. MemoryCoordinatorImpl::GetCurrentMemoryState()
shouldn't return SUSPENDED state. Use THROTTLED state instead.

BUG=659891

Committed: https://crrev.com/0693b4df2baa450f88e4dbefc65a30bafc66e769
Cr-Commit-Position: refs/heads/master@{#427980}
==========

[commit-bot: I haz the power, 2016-10-27 09:42:26]

Patchset 2 (id:??) landed as
https://crrev.com/0693b4df2baa450f88e4dbefc65a30bafc66e769
Cr-Commit-Position: refs/heads/master@{#427980}