Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Issue 2450063002: Disabling WorkerProcessLauncherTest.Crash (Closed)

Created:
4 years, 1 month ago by dmazzoni
Modified:
4 years, 1 month ago
Reviewers:
Sam McNally, Nico
CC:
chromium-reviews, chromoting-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disabling WorkerProcessLauncherTest.Crash It's failing on Win dbg bots BUG=659219 TBR=sammc@chromium.org NOTRY=true Committed: https://crrev.com/4af028e242ed5275e2241f291df47557ec57101b Cr-Commit-Position: refs/heads/master@{#427493}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M remoting/host/win/worker_process_launcher_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2450063002/1
4 years, 1 month ago (2016-10-25 21:43:43 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-25 21:49:25 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4af028e242ed5275e2241f291df47557ec57101b Cr-Commit-Position: refs/heads/master@{#427493}
4 years, 1 month ago (2016-10-25 21:52:18 UTC) #8
Nico
Same question as on the bug: Since a recent CL broke this, why not revert ...
4 years, 1 month ago (2016-10-26 14:06:43 UTC) #10
dmazzoni
Hmmm, good point. I can't recall what I was thinking when I decided to disable ...
4 years, 1 month ago (2016-10-26 15:24:19 UTC) #11
dmazzoni
4 years, 1 month ago (2016-10-26 21:31:12 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2444193008/ by dmazzoni@chromium.org.

The reason for reverting is: Re-enabling now that "Use ChannelMojo between the
remoting daemon and network processes" is reverted (
https://codereview.chromium.org/2424353002/)  http://crbug.com/659219
.

Powered by Google App Engine
This is Rietveld 408576698