Replace Stream with monitor.

Replace Stream with monitor.

TBR

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/d1636b38b31483612a5318dfe70ee758c3380848

[scheglov, 2016-10-26 03:00:25]

Description was changed from

==========
Replace Stream with monitor.

TBR

R=brianwilkerson@google.com, paulberry@google.com
BUG=
==========

to

==========
Replace Stream with monitor.

TBR

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/d1636b38b31483612a5318dfe70ee758c3380848
==========

[scheglov, 2016-10-26 03:00:27]

Committed patchset #1 (id:1) manually as
d1636b38b31483612a5318dfe70ee758c3380848 (presubmit successful).

[Brian Wilkerson, 2016-10-26 08:09:46]

lgtm

[Paul Berry, 2016-10-31 16:40:47]

lgtm

https://codereview.chromium.org/2450053003/diff/1/pkg/analyzer/lib/src/dart/a...
File pkg/analyzer/lib/src/dart/analysis/driver.dart (right):

https://codereview.chromium.org/2450053003/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/driver.dart:187: * when the client cancels
the subscription.
It looks to me like it's not safe to call `.results` more than once on a given
AnalysisDriver.  Is that correct?  If so, could you please add a note to this
effect in the doc comment?

[scheglov, 2016-10-31 17:45:44]

https://codereview.chromium.org/2450053003/diff/1/pkg/analyzer/lib/src/dart/a...
File pkg/analyzer/lib/src/dart/analysis/driver.dart (right):

https://codereview.chromium.org/2450053003/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/driver.dart:187: * when the client cancels
the subscription.
On 2016/10/31 16:40:47, Paul Berry wrote:
> It looks to me like it's not safe to call `.results` more than once on a given
> AnalysisDriver.  Is that correct?  If so, could you please add a note to this
> effect in the doc comment?

Yes, this is a normal Stream, not broadcast.
So, only one subscriber over the lifetime.