Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2450043002: [spv2] Do not use updatePaintOffsetTranslation builder for LayoutView (Closed)

Created:
4 years, 1 month ago by pdr.
Modified:
4 years, 1 month ago
Reviewers:
Xianzhu, trchen
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[spv2] Do not use updatePaintOffsetTranslation builder for LayoutView This refactoring moves the LayoutView special-case to the top of PaintPropertyTreeBuilder::updatePaintOffsetTranslation, making it clear that the function does not apply to LayoutView. A comment has been added to describe how LayoutView's paint offset is updated in the FrameView update. BUG=645667 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/cf5f1d5f287d15d220a88e4185a3b09a9e9fd361 Cr-Commit-Position: refs/heads/master@{#427476}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp View 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
pdr.
Another small cleanup. The added assert proves there is no change in behavior.
4 years, 1 month ago (2016-10-25 20:41:35 UTC) #5
Xianzhu
lgtm
4 years, 1 month ago (2016-10-25 20:47:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2450043002/1
4 years, 1 month ago (2016-10-25 21:14:45 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-25 21:22:11 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 21:27:47 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cf5f1d5f287d15d220a88e4185a3b09a9e9fd361
Cr-Commit-Position: refs/heads/master@{#427476}

Powered by Google App Engine
This is Rietveld 408576698