Add UTF8String to the banned method list.

Add UTF8String to the banned method list.

NSString's UTF8String can return null for some NSStrings, even if
|canBeConvertedToEncoding:NSUTF8StringEncoding| returns YES.
This has led to at least 2 crashes that were not encountered during
the development period.

BUG=659649, 656108, 653379
Committed: https://crrev.com/6539870a0bbb33b28a1b56c85124874eb22c9e68
Cr-Commit-Position: refs/heads/master@{#427991}

[jif, 2016-10-26 13:03:47]

Description was changed from

==========
Add UTF8String to the banned method list.

NSString's UTF8String can return null for some NSStrings, even if
|canBeConvertedToEncoding:NSUTF8StringEncoding| returns YES.
This has led to at least 2 crashes that were not encountered during
the development period.

BUG=656108, 653379
==========

to

==========
Add UTF8String to the banned method list.

NSString's UTF8String can return null for some NSStrings, even if
|canBeConvertedToEncoding:NSUTF8StringEncoding| returns YES.
This has led to at least 2 crashes that were not encountered during
the development period.

BUG=656108, 653379
==========

[jif, 2016-10-26 13:03:47]

jif@chromium.org changed reviewers:
+ dpranke@chromium.org

[jif, 2016-10-26 13:14:18]

ptal

[jif-google, 2016-10-26 14:34:16]

Description was changed from

==========
Add UTF8String to the banned method list.

NSString's UTF8String can return null for some NSStrings, even if
|canBeConvertedToEncoding:NSUTF8StringEncoding| returns YES.
This has led to at least 2 crashes that were not encountered during
the development period.

BUG=656108, 653379
==========

to

==========
Add UTF8String to the banned method list.

NSString's UTF8String can return null for some NSStrings, even if
|canBeConvertedToEncoding:NSUTF8StringEncoding| returns YES.
This has led to at least 2 crashes that were not encountered during
the development period.

BUG=659649, 656108, 653379
==========

[Dirk Pranke, 2016-10-26 17:26:33]

lgtm

[jif, 2016-10-27 09:22:13]

The CQ bit was checked by jif@chromium.org

[commit-bot: I haz the power, 2016-10-27 09:22:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 10:20:13]

Description was changed from

==========
Add UTF8String to the banned method list.

NSString's UTF8String can return null for some NSStrings, even if
|canBeConvertedToEncoding:NSUTF8StringEncoding| returns YES.
This has led to at least 2 crashes that were not encountered during
the development period.

BUG=659649, 656108, 653379
==========

to

==========
Add UTF8String to the banned method list.

NSString's UTF8String can return null for some NSStrings, even if
|canBeConvertedToEncoding:NSUTF8StringEncoding| returns YES.
This has led to at least 2 crashes that were not encountered during
the development period.

BUG=659649, 656108, 653379
==========

[commit-bot: I haz the power, 2016-10-27 10:20:14]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-27 10:22:54]

Description was changed from

==========
Add UTF8String to the banned method list.

NSString's UTF8String can return null for some NSStrings, even if
|canBeConvertedToEncoding:NSUTF8StringEncoding| returns YES.
This has led to at least 2 crashes that were not encountered during
the development period.

BUG=659649, 656108, 653379
==========

to

==========
Add UTF8String to the banned method list.

NSString's UTF8String can return null for some NSStrings, even if
|canBeConvertedToEncoding:NSUTF8StringEncoding| returns YES.
This has led to at least 2 crashes that were not encountered during
the development period.

BUG=659649, 656108, 653379

Committed: https://crrev.com/6539870a0bbb33b28a1b56c85124874eb22c9e68
Cr-Commit-Position: refs/heads/master@{#427991}
==========

[commit-bot: I haz the power, 2016-10-27 10:22:54]

Patchset 1 (id:??) landed as
https://crrev.com/6539870a0bbb33b28a1b56c85124874eb22c9e68
Cr-Commit-Position: refs/heads/master@{#427991}