Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 2450033002: Refine the criteria for ScrollAnchor-disabling properties (Closed)

Created:
4 years, 1 month ago by ymalik
Modified:
4 years, 1 month ago
Reviewers:
skobes, ojan
CC:
chromium-reviews, blink-reviews, blink-reviews-style_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refine the criteria for ScrollAnchor-disabling properties The change of the following CSS properties on an anchor node's ancestor causes anchoring suppresion: - left, top, right, bottom - margin-left, margin-top, margin-right, margin-bottom - padding-left, padding-top, padding-right, padding-bottom - width, min-width, max-width, height, min-height, max-height - position, transform - shorthands for the above BUG=658834 Committed: https://crrev.com/85861c2144feef2c65bb34f3bcc36e3d57180cb5 Cr-Commit-Position: refs/heads/master@{#427584}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -3 lines) Patch
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 2 chunks +30 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
ymalik
4 years, 1 month ago (2016-10-25 19:07:45 UTC) #3
skobes
lgtm
4 years, 1 month ago (2016-10-25 23:17:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2450033002/1
4 years, 1 month ago (2016-10-26 02:56:38 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-26 04:03:48 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 04:08:35 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/85861c2144feef2c65bb34f3bcc36e3d57180cb5
Cr-Commit-Position: refs/heads/master@{#427584}

Powered by Google App Engine
This is Rietveld 408576698