Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2450003002: Disable data_reduction_proxy unit tests on iOS. (Closed)

Created:
4 years, 1 month ago by sdefresne
Modified:
4 years, 1 month ago
Reviewers:
blundell
CC:
chromium-reviews, mef
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable data_reduction_proxy unit tests on iOS. With the switch to WKWebView, Chrome on iOS code cannot use data reduction proxy. Disable the tests on iOS as they are flaky and make components_unittests falky on iOS. BUG=658619 Committed: https://crrev.com/59da38fdd532f99ab0f9020f861da209178ae334 Cr-Commit-Position: refs/heads/master@{#427432}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M components/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
sdefresne
Please take a look and send to CQ if lgty.
4 years, 1 month ago (2016-10-25 17:45:58 UTC) #3
blundell
lgtm mef@: the whole layered component structure of DRP could probably be torn down now?
4 years, 1 month ago (2016-10-25 17:55:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2450003002/1
4 years, 1 month ago (2016-10-25 17:56:12 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-25 19:05:10 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 19:09:32 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/59da38fdd532f99ab0f9020f861da209178ae334
Cr-Commit-Position: refs/heads/master@{#427432}

Powered by Google App Engine
This is Rietveld 408576698