Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Side by Side Diff: ui/gl/gl_image_egl.cc

Issue 2449993005: Remove GLImage::Destroy(). (Closed)
Patch Set: Remove GLImage::Destroy(). Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/gl/gl_image_egl.h" 5 #include "ui/gl/gl_image_egl.h"
6 6
7 #include "ui/gl/egl_util.h" 7 #include "ui/gl/egl_util.h"
8 #include "ui/gl/gl_surface_egl.h" 8 #include "ui/gl/gl_surface_egl.h"
9 9
10 namespace gl { 10 namespace gl {
11 11
12 GLImageEGL::GLImageEGL(const gfx::Size& size) 12 GLImageEGL::GLImageEGL(const gfx::Size& size)
13 : egl_image_(EGL_NO_IMAGE_KHR), size_(size) {} 13 : egl_image_(EGL_NO_IMAGE_KHR), size_(size) {}
14 14
15 GLImageEGL::~GLImageEGL() { 15 GLImageEGL::~GLImageEGL() {
16 DCHECK(thread_checker_.CalledOnValidThread()); 16 DCHECK(thread_checker_.CalledOnValidThread());
17 DCHECK_EQ(EGL_NO_IMAGE_KHR, egl_image_); 17 if (egl_image_ != EGL_NO_IMAGE_KHR) {
18 EGLBoolean result =
19 eglDestroyImageKHR(GLSurfaceEGL::GetHardwareDisplay(), egl_image_);
20 if (result == EGL_FALSE) {
21 DLOG(ERROR) << "Error destroying EGLImage: "
22 << ui::GetLastEGLErrorString();
23 }
24 egl_image_ = EGL_NO_IMAGE_KHR;
reveman 2016/10/27 20:01:44 nit: no need for this in dtor
sandersd (OOO until July 31) 2016/10/27 20:13:09 Done.
25 }
18 } 26 }
19 27
20 bool GLImageEGL::Initialize(EGLenum target, 28 bool GLImageEGL::Initialize(EGLenum target,
21 EGLClientBuffer buffer, 29 EGLClientBuffer buffer,
22 const EGLint* attrs) { 30 const EGLint* attrs) {
23 DCHECK(thread_checker_.CalledOnValidThread()); 31 DCHECK(thread_checker_.CalledOnValidThread());
24 DCHECK_EQ(EGL_NO_IMAGE_KHR, egl_image_); 32 DCHECK_EQ(EGL_NO_IMAGE_KHR, egl_image_);
25 egl_image_ = eglCreateImageKHR(GLSurfaceEGL::GetHardwareDisplay(), 33 egl_image_ = eglCreateImageKHR(GLSurfaceEGL::GetHardwareDisplay(),
26 EGL_NO_CONTEXT, target, buffer, attrs); 34 EGL_NO_CONTEXT, target, buffer, attrs);
27 if (egl_image_ == EGL_NO_IMAGE_KHR) { 35 if (egl_image_ == EGL_NO_IMAGE_KHR) {
28 DLOG(ERROR) << "Error creating EGLImage: " << ui::GetLastEGLErrorString(); 36 DLOG(ERROR) << "Error creating EGLImage: " << ui::GetLastEGLErrorString();
29 return false; 37 return false;
30 } 38 }
31 39
32 return true; 40 return true;
33 } 41 }
34 42
35 void GLImageEGL::Destroy(bool have_context) {
36 DCHECK(thread_checker_.CalledOnValidThread());
37 if (egl_image_ != EGL_NO_IMAGE_KHR) {
38 EGLBoolean result =
39 eglDestroyImageKHR(GLSurfaceEGL::GetHardwareDisplay(), egl_image_);
40 if (result == EGL_FALSE) {
41 DLOG(ERROR) << "Error destroying EGLImage: "
42 << ui::GetLastEGLErrorString();
43 }
44 egl_image_ = EGL_NO_IMAGE_KHR;
45 }
46 }
47
48 gfx::Size GLImageEGL::GetSize() { 43 gfx::Size GLImageEGL::GetSize() {
49 return size_; 44 return size_;
50 } 45 }
51 46
52 unsigned GLImageEGL::GetInternalFormat() { return GL_RGBA; } 47 unsigned GLImageEGL::GetInternalFormat() { return GL_RGBA; }
53 48
54 bool GLImageEGL::BindTexImage(unsigned target) { 49 bool GLImageEGL::BindTexImage(unsigned target) {
55 DCHECK(thread_checker_.CalledOnValidThread()); 50 DCHECK(thread_checker_.CalledOnValidThread());
56 if (egl_image_ == EGL_NO_IMAGE_KHR) 51 if (egl_image_ == EGL_NO_IMAGE_KHR)
57 return false; 52 return false;
(...skipping 15 matching lines...) Expand all
73 68
74 bool GLImageEGL::ScheduleOverlayPlane(gfx::AcceleratedWidget widget, 69 bool GLImageEGL::ScheduleOverlayPlane(gfx::AcceleratedWidget widget,
75 int z_order, 70 int z_order,
76 gfx::OverlayTransform transform, 71 gfx::OverlayTransform transform,
77 const gfx::Rect& bounds_rect, 72 const gfx::Rect& bounds_rect,
78 const gfx::RectF& crop_rect) { 73 const gfx::RectF& crop_rect) {
79 return false; 74 return false;
80 } 75 }
81 76
82 } // namespace gl 77 } // namespace gl
OLDNEW
« no previous file with comments | « ui/gl/gl_image_egl.h ('k') | ui/gl/gl_image_glx.h » ('j') | ui/gl/gl_image_glx.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698