Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issue 2449973004: Reland of Improve linearized pdf load/show time. (Closed)

Created:
4 years, 1 month ago by hongchan
Modified:
4 years, 1 month ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Improve linearized pdf load/show time. (patchset #1 id:1 of https://codereview.chromium.org/2458493002/ ) Reason for revert: As suggested FindIt, this reverting CL is also causing the tree closure. Original issue's description: > Revert of Improve linearized pdf load/show time. (patchset #18 id:340001 of https://codereview.chromium.org/2349753003/ ) > > Reason for revert: > https://build.chromium.org/p/chromium/builders/Win%20x64/builds/5423/steps/compile/logs/stdio > > FAILED: obj/pdf/pdf_unittests/document_loader_unittest.obj > pdf\document_loader_unittest.cc(631): error C2131: expression did not evaluate to a constant > pdf\document_loader_unittest.cc(631): note: failure was caused by call of undefined function or one not declared 'constexpr' > pdf\document_loader_unittest.cc(631): note: see usage of 'chrome_pdf::DocumentLoader::default_request_size' > > > Original issue's description: > > Improve linearized pdf load/show time. > > Reduce Pdf Plugin's count of reconnects. > > Add tests for PDFPlugin DocumentLoader. > > > > DocumentLoader was splitted into separate components, and missing tests was added for them. > > > > The main ideas in this CL are: > > > > 1) Do not reset browser initiated connection at start (includes case when we can use range requests), if we request data near current downloading position. > > 2) Request as much data as we can on each request, and continue loading data using current range request. (like tape rewind) > > 3) Isolate RangeRequest logic into DocumentLoader. Method OnPendingRequestComplete is called, when we receive requested data (main connection, or Range connection). (like tape playing without rewing). > > 4) Fill this logic by tests. > > > > Example URL: > > http://www.major-landrover.ru/upload/attachments/f/9/f96aab07dab04ae89c8a509ec1ef2b31.pdf > > Comparison of changes: > > https://drive.google.com/file/d/0BzWfMBOuik2QNGg0SG93Y3lpUlE/view?usp=sharing > > > > Committed: https://crrev.com/7fd7423cdee0dba84faf480d10dd66dcb57110d9 > > Cr-Commit-Position: refs/heads/master@{#427752} > > TBR=jochen@chromium.org,raymes@chromium.org,spelchat@chromium.org,rsesek@chromium.org,art-snake@yandex-team.ru > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true TBR=jochen@chromium.org,raymes@chromium.org,spelchat@chromium.org,rsesek@chromium.org,art-snake@yandex-team.ru,thestig@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/47b9a19cb7219538a26e0f1388fd01adac709b98 Cr-Commit-Position: refs/heads/master@{#427782}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3032 lines, -789 lines) Patch
M pdf/BUILD.gn View 4 chunks +29 lines, -1 line 0 comments Download
M pdf/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M pdf/chunk_stream.h View 1 chunk +81 lines, -24 lines 0 comments Download
D pdf/chunk_stream.cc View 1 chunk +0 lines, -175 lines 0 comments Download
A pdf/chunk_stream_unittest.cc View 1 chunk +99 lines, -0 lines 0 comments Download
M pdf/document_loader.h View 3 chunks +48 lines, -62 lines 0 comments Download
M pdf/document_loader.cc View 4 chunks +282 lines, -436 lines 0 comments Download
A pdf/document_loader_unittest.cc View 1 chunk +1184 lines, -0 lines 0 comments Download
M pdf/out_of_process_instance.h View 1 chunk +1 line, -0 lines 0 comments Download
M pdf/out_of_process_instance.cc View 2 chunks +6 lines, -9 lines 0 comments Download
M pdf/pdf_engine.h View 2 chunks +3 lines, -2 lines 0 comments Download
M pdf/pdfium/pdfium_engine.h View 4 chunks +11 lines, -6 lines 0 comments Download
M pdf/pdfium/pdfium_engine.cc View 16 chunks +92 lines, -74 lines 0 comments Download
M pdf/preview_mode_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M pdf/preview_mode_client.cc View 1 chunk +2 lines, -0 lines 0 comments Download
A pdf/range_set.h View 1 chunk +77 lines, -0 lines 0 comments Download
A pdf/range_set.cc View 1 chunk +253 lines, -0 lines 0 comments Download
A pdf/range_set_unittest.cc View 1 chunk +303 lines, -0 lines 0 comments Download
A pdf/run_all_unittests.cc View 1 chunk +24 lines, -0 lines 0 comments Download
A pdf/timer.h View 1 chunk +35 lines, -0 lines 0 comments Download
A pdf/timer.cc View 1 chunk +31 lines, -0 lines 0 comments Download
A pdf/url_loader_wrapper.h View 1 chunk +62 lines, -0 lines 0 comments Download
A pdf/url_loader_wrapper_impl.h View 1 chunk +89 lines, -0 lines 0 comments Download
A pdf/url_loader_wrapper_impl.cc View 1 chunk +318 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
hongchan
Created Reland of Improve linearized pdf load/show time.
4 years, 1 month ago (2016-10-26 19:57:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2449973004/1
4 years, 1 month ago (2016-10-26 19:57:46 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-26 19:59:04 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/47b9a19cb7219538a26e0f1388fd01adac709b98 Cr-Commit-Position: refs/heads/master@{#427782}
4 years, 1 month ago (2016-10-26 20:00:37 UTC) #6
Lei Zhang
Sorry, but re-applying a CL that is known to break the tree is not the ...
4 years, 1 month ago (2016-10-26 20:38:00 UTC) #7
Lei Zhang
4 years, 1 month ago (2016-10-26 20:42:46 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2456653002/ by thestig@chromium.org.

The reason for reverting is: Still breaks the tree. The initial revert failed
due to funny merging by the CQ in reaction to r427683..

Powered by Google App Engine
This is Rietveld 408576698