Fix bug in service worker push tests: don't cache subscription options

chrome/test/data/push_messaging/service_worker.js

Index: chrome/test/data/push_messaging/service_worker.js
diff --git a/chrome/test/data/push_messaging/service_worker.js b/chrome/test/data/push_messaging/service_worker.js
index f32068849a8fb2b3995e84fd895d82133efc97a0..56fc226446fac60dd492f0f8233f27ffd1872c1c 100644
--- a/chrome/test/data/push_messaging/service_worker.js
+++ b/chrome/test/data/push_messaging/service_worker.js
@@ -6,10 +6,6 @@
 // which would affect the scope of the importScripts call here.
 self.importScripts('/push_messaging/push_constants.js');
 
-var pushSubscriptionOptions = {
-    userVisibleOnly: true
-};
-
 // The "onpush" event currently understands two values as message payload
 // data coming from the test. Any other input is passed through to the
 // document unchanged.
@@ -47,6 +43,9 @@ this.onpush = function(event) {
 };
 
 self.addEventListener('message', function handler (event) {
+  var pushSubscriptionOptions = {
+        userVisibleOnly: true

[Peter Beverloo, 2016/10/27 17:17:59]

nit: please use 4 space indent for dictionary values. May also want to
s/var/let/ while you're here.

[awdf, 2016/10/27 17:34:39]

Done.

+  };
   if (event.data.command == 'workerSubscribe') {
     pushSubscriptionOptions.applicationServerKey = kApplicationServerKey.buffer;
   } else if (event.data.command == 'workerSubscribeNoKey') {