Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1157)

Unified Diff: content/browser/loader/url_loader_factory_impl_unittest.cc

Issue 2449933003: Use Associated interfaces for mojo-loading (Closed)
Patch Set: fix Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/loader/url_loader_factory_impl_unittest.cc
diff --git a/content/browser/loader/url_loader_factory_impl_unittest.cc b/content/browser/loader/url_loader_factory_impl_unittest.cc
index 84d082b6292f71cd70aa981752d64682108aa923..3abba9993dabab4b8f29fa5fbb98d9ebce8c9d8c 100644
--- a/content/browser/loader/url_loader_factory_impl_unittest.cc
+++ b/content/browser/loader/url_loader_factory_impl_unittest.cc
@@ -136,7 +136,7 @@ TEST_P(URLLoaderFactoryImplTest, GetResponse) {
constexpr int32_t kRoutingId = 81;
constexpr int32_t kRequestId = 28;
NavigationResourceThrottle::set_ui_checks_always_succeed_for_testing(true);
- mojom::URLLoaderPtr loader;
+ mojom::URLLoaderAssociatedPtr loader;
base::FilePath root;
PathService::Get(DIR_TEST_DATA, &root);
net::URLRequestMockHTTPJob::AddUrlHandlers(root,
@@ -147,9 +147,10 @@ TEST_P(URLLoaderFactoryImplTest, GetResponse) {
request.url = net::URLRequestMockHTTPJob::GetMockUrl("hello.html");
request.method = "GET";
request.is_main_frame = true;
- factory_->CreateLoaderAndStart(mojo::GetProxy(&loader), kRoutingId,
- kRequestId, request,
- client.CreateInterfacePtrAndBind());
+ factory_->CreateLoaderAndStart(
+ mojo::GetProxy(&loader, factory_.associated_group()), kRoutingId,
+ kRequestId, request,
+ client.CreateRemoteAssociatedPtrInfo(factory_.associated_group()));
ASSERT_FALSE(client.has_received_response());
ASSERT_FALSE(client.response_body().is_valid());
@@ -204,15 +205,16 @@ TEST_P(URLLoaderFactoryImplTest, GetResponse) {
TEST_P(URLLoaderFactoryImplTest, GetFailedResponse) {
NavigationResourceThrottle::set_ui_checks_always_succeed_for_testing(true);
- mojom::URLLoaderPtr loader;
+ mojom::URLLoaderAssociatedPtr loader;
ResourceRequest request;
TestURLLoaderClient client;
net::URLRequestFailedJob::AddUrlHandler();
request.url = net::URLRequestFailedJob::GetMockHttpUrlWithFailurePhase(
net::URLRequestFailedJob::START, net::ERR_TIMED_OUT);
request.method = "GET";
- factory_->CreateLoaderAndStart(mojo::GetProxy(&loader), 2, 1, request,
- client.CreateInterfacePtrAndBind());
+ factory_->CreateLoaderAndStart(
+ mojo::GetProxy(&loader, factory_.associated_group()), 2, 1, request,
+ client.CreateRemoteAssociatedPtrInfo(factory_.associated_group()));
client.RunUntilComplete();
ASSERT_FALSE(client.has_received_response());
@@ -223,14 +225,15 @@ TEST_P(URLLoaderFactoryImplTest, GetFailedResponse) {
// This test tests a case where resource loading is cancelled before started.
TEST_P(URLLoaderFactoryImplTest, InvalidURL) {
- mojom::URLLoaderPtr loader;
+ mojom::URLLoaderAssociatedPtr loader;
ResourceRequest request;
TestURLLoaderClient client;
request.url = GURL();
request.method = "GET";
ASSERT_FALSE(request.url.is_valid());
- factory_->CreateLoaderAndStart(mojo::GetProxy(&loader), 2, 1, request,
- client.CreateInterfacePtrAndBind());
+ factory_->CreateLoaderAndStart(
+ mojo::GetProxy(&loader, factory_.associated_group()), 2, 1, request,
+ client.CreateRemoteAssociatedPtrInfo(factory_.associated_group()));
client.RunUntilComplete();
ASSERT_FALSE(client.has_received_response());
@@ -241,15 +244,16 @@ TEST_P(URLLoaderFactoryImplTest, InvalidURL) {
// This test tests a case where resource loading is cancelled before started.
TEST_P(URLLoaderFactoryImplTest, ShouldNotRequestURL) {
- mojom::URLLoaderPtr loader;
+ mojom::URLLoaderAssociatedPtr loader;
RejectingResourceDispatcherHostDelegate rdh_delegate;
rdh_.SetDelegate(&rdh_delegate);
ResourceRequest request;
TestURLLoaderClient client;
request.url = GURL("http://localhost/");
request.method = "GET";
- factory_->CreateLoaderAndStart(mojo::GetProxy(&loader), 2, 1, request,
- client.CreateInterfacePtrAndBind());
+ factory_->CreateLoaderAndStart(
+ mojo::GetProxy(&loader, factory_.associated_group()), 2, 1, request,
+ client.CreateRemoteAssociatedPtrInfo(factory_.associated_group()));
client.RunUntilComplete();
rdh_.SetDelegate(nullptr);

Powered by Google App Engine
This is Rietveld 408576698