Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2449933002: Reland of gpu, cmaa: add glApplyScreenSpaceAntialiasingCHROMIUM unittests (https://codereview.chrom… (Closed)

Created:
4 years, 1 month ago by dshwang
Modified:
4 years, 1 month ago
CC:
chromium-reviews, piman+watch_chromium.org, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of gpu, cmaa: add glApplyScreenSpaceAntialiasingCHROMIUM unittests (https://codereview.chromium.org/2432413003/) Reason for revert: New unittests crash due to deleting null texture. This CL handles it to reland. BUG=535198 > Revert of gpu, cmaa: add glApplyScreenSpaceAntialiasingCHROMIUM unittests (patchset #4 id:60001 of https://codereview.chromium.org/2432413003/ ) > > Reason for revert: > The tests added here are crashing on an assertion on multiple GPU Debug bots. For example: > https://build.chromium.org/p/chromium.gpu/builders/Mac%2010.10%20Retina%20Debug%20%28AMD%29/builds/18115 > https://build.chromium.org/p/chromium.gpu/builders/Win7%20Debug%20%28NVIDIA%29/builds/45966 > > Snippet from the log: > [548:3764:1025/061243:2681579:FATAL:gles2_implementation_impl_autogen.h(606)] Check failed: textures[i] != 0. > Backtrace: > base::debug::StackTrace::StackTrace [0x00A7B3E7+23] > logging::LogMessage::~LogMessage [0x00ACD4EB+59] > gpu::gles2::GLES2Implementation::DeleteTextures [0x03DB1732+626] > GLES2DeleteTextures [0x03EB5954+36] > gpu::GLApplyScreenSpaceAntialiasingCHROMIUMTest::TearDown [0x00442AC8+24] > > Original issue's description: > > gpu, cmaa: add glApplyScreenSpaceAntialiasingCHROMIUM unittests > > > > Add new unittests for glApplyScreenSpaceAntialiasingCHROMIUM, which check the > > conformance with GL_INTEL_framebuffer_CMAA spec [1]. > > > > Many tests are very similar to tests of GLCopyTextureCHROMIUMTest. > > > > [1] https://www.khronos.org/registry/gles/extensions/INTEL/framebuffer_CMAA.txt > > > > BUG=535198 > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > > > Committed: https://crrev.com/a5d6052cdc38c8d12bb7d4686177d67809b1f66e > > Cr-Commit-Position: refs/heads/master@{#427326} > > TBR=dongseong.hwang@chromium.org,piman@chromium.org,adrian.belgun@intel.com,dongseong.hwang@intel.com > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=535198 > > Review-Url: https://codereview.chromium.org/2451803002 > Cr-Commit-Position: refs/heads/master@{#427335} CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/e727a7e700cfdce175091ca742a4b32592330e25 Cr-Commit-Position: refs/heads/master@{#427475}

Patch Set 1 #

Patch Set 2 : diff to reland #

Unified diffs Side-by-side diffs Delta from patch set Stats (+448 lines, -2 lines) Patch
M gpu/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/GLES2/extensions/CHROMIUM/CHROMIUM_screen_space_antialiasing.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 2 chunks +12 lines, -2 lines 0 comments Download
A gpu/command_buffer/tests/gl_apply_screen_space_antialiasing_CHROMIUM_unittest.cc View 1 1 chunk +433 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
dshwang
piman@, could you review again? The diff between patch 1 and patch 2 is the ...
4 years, 1 month ago (2016-10-25 14:25:32 UTC) #5
piman
lgtm
4 years, 1 month ago (2016-10-25 19:21:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2449933002/20001
4 years, 1 month ago (2016-10-25 21:07:59 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-25 21:19:02 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 21:20:41 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e727a7e700cfdce175091ca742a4b32592330e25
Cr-Commit-Position: refs/heads/master@{#427475}

Powered by Google App Engine
This is Rietveld 408576698