DescriptionReland of gpu, cmaa: add glApplyScreenSpaceAntialiasingCHROMIUM unittests (https://codereview.chromium.org/2432413003/)
Reason for revert:
New unittests crash due to deleting null texture. This CL handles it to reland.
BUG=535198
> Revert of gpu, cmaa: add glApplyScreenSpaceAntialiasingCHROMIUM unittests (patchset #4 id:60001 of https://codereview.chromium.org/2432413003/ )
>
> Reason for revert:
> The tests added here are crashing on an assertion on multiple GPU Debug bots. For example:
> https://build.chromium.org/p/chromium.gpu/builders/Mac%2010.10%20Retina%20Debug%20%28AMD%29/builds/18115
> https://build.chromium.org/p/chromium.gpu/builders/Win7%20Debug%20%28NVIDIA%29/builds/45966
>
> Snippet from the log:
> [548:3764:1025/061243:2681579:FATAL:gles2_implementation_impl_autogen.h(606)] Check failed: textures[i] != 0.
> Backtrace:
> base::debug::StackTrace::StackTrace [0x00A7B3E7+23]
> logging::LogMessage::~LogMessage [0x00ACD4EB+59]
> gpu::gles2::GLES2Implementation::DeleteTextures [0x03DB1732+626]
> GLES2DeleteTextures [0x03EB5954+36]
> gpu::GLApplyScreenSpaceAntialiasingCHROMIUMTest::TearDown [0x00442AC8+24]
>
> Original issue's description:
> > gpu, cmaa: add glApplyScreenSpaceAntialiasingCHROMIUM unittests
> >
> > Add new unittests for glApplyScreenSpaceAntialiasingCHROMIUM, which check the
> > conformance with GL_INTEL_framebuffer_CMAA spec [1].
> >
> > Many tests are very similar to tests of GLCopyTextureCHROMIUMTest.
> >
> > [1] https://www.khronos.org/registry/gles/extensions/INTEL/framebuffer_CMAA.txt
> >
> > BUG=535198
> > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> >
> > Committed: https://crrev.com/a5d6052cdc38c8d12bb7d4686177d67809b1f66e
> > Cr-Commit-Position: refs/heads/master@{#427326}
>
> TBR=dongseong.hwang@chromium.org,piman@chromium.org,adrian.belgun@intel.com,dongseong.hwang@intel.com
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=535198
>
> Review-Url: https://codereview.chromium.org/2451803002
> Cr-Commit-Position: refs/heads/master@{#427335}
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Committed: https://crrev.com/e727a7e700cfdce175091ca742a4b32592330e25
Cr-Commit-Position: refs/heads/master@{#427475}
Patch Set 1 #Patch Set 2 : diff to reland #
Messages
Total messages: 15 (10 generated)
|