extensions/common/api/web_request.json - Issue 2449913002: Support WebSocket in WebRequest API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/api/web_request.json

Issue 2449913002: Support WebSocket in WebRequest API. (Closed)

Patch Set: Add tests for onAuthRequired path for WS handshake. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/browser/api/web_request/web_request_api.cc ('K') | « extensions/browser/api/web_request/web_request_permissions.cc ('k') | extensions/common/extension.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/common/api/web_request.json

diff --git a/extensions/common/api/web_request.json b/extensions/common/api/web_request.json

index b676a02f8361fa6481274875b9ffac331ee79421..5f1ccb1edd13d254ce8e7b6028420189882fc349 100644

--- a/extensions/common/api/web_request.json

+++ b/extensions/common/api/web_request.json

@@ -111,7 +111,7 @@

"redirectUrl": {

"type": "string",

"optional": true,

- "description": "Only used as a response to the onBeforeRequest and onHeadersReceived events. If set, the original request is prevented from being sent/completed and is instead redirected to the given URL. Redirections to non-HTTP schemes such as data: are allowed. Redirects initiated by a redirect action use the original request method for the redirect, with one exception: If the redirect is initiated at the onHeadersReceived stage, then the redirect will be issued using the GET method."

+ "description": "Only used as a response to the onBeforeRequest and onHeadersReceived events. If set, the original request is prevented from being sent/completed and is instead redirected to the given URL. Redirections to non-HTTP schemes such as <code>data://</code> are allowed. Redirects initiated by a redirect action use the original request method for the redirect, with one exception: If the redirect is initiated at the onHeadersReceived stage, then the redirect will be issued using the GET method. Redirects from URLs with <code>ws://</code> and <code>wss://</code> schemes are <b>ignored</b>."

Devlin 2017/02/21 16:10:44 nit: While data: is technically a scheme, I don't

pkalinnikov 2017/02/21 19:18:16 Done.

"requestHeaders": {

"$ref": "HttpHeaders",