Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2449903002: [ObjC ARC] Converts ios/web/app to ARC (Closed)

Created:
4 years, 1 month ago by stkhapugin
Modified:
4 years, 1 month ago
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/web/app to ARC Notable changes: none BUG=624365 TEST=None Committed: https://crrev.com/ee84494fa63915bf539470d3d334649d8ef7cbc8 Cr-Commit-Position: refs/heads/master@{#427347}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M ios/web/app/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M ios/web/app/web_main.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web/app/web_main_loop.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web/app/web_main_runner.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
stkhapugin
PTAL
4 years, 1 month ago (2016-10-25 14:25:38 UTC) #6
marq (ping after 24h)
lgtm LGTM
4 years, 1 month ago (2016-10-25 14:35:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2449903002/1
4 years, 1 month ago (2016-10-25 14:38:07 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-25 14:43:06 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 14:45:17 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ee84494fa63915bf539470d3d334649d8ef7cbc8
Cr-Commit-Position: refs/heads/master@{#427347}

Powered by Google App Engine
This is Rietveld 408576698