Issue 24499002: Reload wallpaper when display configuration changes.

Issue 24499002: Reload wallpaper when display configuration changes. (Closed)

Created:
7 years, 2 months ago by oshima

Modified:
7 years, 2 months ago

Reviewers:
bshe

CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, ben+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Reload wallpaper when display configuration changes. BUG=285365, 239849 R=bshe@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=225386

Patch Set 2 : #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+242 lines, -69 lines)			Patch
M	ash/ash.gyp	View		2 chunks	+4 lines, -0 lines	0 comments	Download
A	ash/default_user_wallpaper_delegate.h	View		1 chunk	+36 lines, -0 lines	0 comments	Download
A	ash/default_user_wallpaper_delegate.cc	View		1 chunk	+41 lines, -0 lines	0 comments	Download
M	ash/desktop_background/desktop_background_controller.h	View		5 chunks	+20 lines, -1 line	0 comments	Download
M	ash/desktop_background/desktop_background_controller.cc	View		6 chunks	+34 lines, -16 lines	0 comments	Download
M	ash/desktop_background/desktop_background_controller_unittest.cc	View	1	5 chunks	+48 lines, -7 lines	0 comments	Download
M	ash/shell.cc	View		3 chunks	+1 line, -43 lines	0 comments	Download
M	ash/shell/shell_delegate_impl.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	ash/test/test_shell_delegate.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
A	ash/test/test_user_wallpaper_delegate.h	View		1 chunk	+32 lines, -0 lines	0 comments	Download
A	ash/test/test_user_wallpaper_delegate.cc	View		1 chunk	+22 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

bshe

lgtm https://codereview.chromium.org/24499002/diff/12001/ash/desktop_background/desktop_background_controller_unittest.cc File ash/desktop_background/desktop_background_controller_unittest.cc (right): https://codereview.chromium.org/24499002/diff/12001/ash/desktop_background/desktop_background_controller_unittest.cc#newcode481 ash/desktop_background/desktop_background_controller_unittest.cc:481: EXPECT_EQ(1, nit: probably move this EXPECT_EQ after line ...

7 years, 2 months ago (2013-09-25 21:00:17 UTC) #2

oshima

https://codereview.chromium.org/24499002/diff/12001/ash/desktop_background/desktop_background_controller_unittest.cc File ash/desktop_background/desktop_background_controller_unittest.cc (right): https://codereview.chromium.org/24499002/diff/12001/ash/desktop_background/desktop_background_controller_unittest.cc#newcode481 ash/desktop_background/desktop_background_controller_unittest.cc:481: EXPECT_EQ(1, On 2013/09/25 21:00:17, bshe wrote: > nit: probably ...

7 years, 2 months ago (2013-09-25 22:29:52 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/24499002/16001

7 years, 2 months ago (2013-09-25 22:31:12 UTC) #4

oshima

7 years, 2 months ago (2013-09-26 07:57:14 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r225386 (presubmit successful).

Expand Messages | Collapse Messages