chrome/common/DEPS - Issue 2449873005: include boringssl headers from third_party explicitly

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/DEPS

Issue 2449873005: include boringssl headers from third_party explicitly (Closed)

Patch Set: review comments Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/ui/website_settings/website_settings.cc ('k') | chrome/common/extensions/api/networking_private/networking_private_crypto.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+chrome/grit",	2 "+chrome/grit",

3 "+chromeos", # For chromeos_switches.h	3 "+chromeos", # For chromeos_switches.h

4 "+components/autofill/content/common",	4 "+components/autofill/content/common",

5 "+components/autofill/core/common",	5 "+components/autofill/core/common",

6 "+components/bookmarks/common",	6 "+components/bookmarks/common",

7 "+components/cast_certificate",	7 "+components/cast_certificate",

8 "+components/cdm/common",	8 "+components/cdm/common",

9 "+components/cloud_devices/common",	9 "+components/cloud_devices/common",

10 "+components/content_settings/core/common",	10 "+components/content_settings/core/common",

(...skipping 15 matching lines...) Expand all Loading...
26 "+components/url_formatter",	26 "+components/url_formatter",

27 "+components/version_info",	27 "+components/version_info",

28 "+extensions/common",	28 "+extensions/common",

29 "+gin/public", # For profiling.cc	29 "+gin/public", # For profiling.cc

30 "+google_apis/gaia", # For gaia_switches.h	30 "+google_apis/gaia", # For gaia_switches.h

31 "+media",	31 "+media",

32 "+ppapi/c",	32 "+ppapi/c",

33 "+ppapi/shared_impl",	33 "+ppapi/shared_impl",

34 "+ppapi/thunk",	34 "+ppapi/thunk",

35 "+sandbox/linux/services/credentials.h",	35 "+sandbox/linux/services/credentials.h",

	36 "+third_party/boringssl/src/include",
	Lei Zhang 2016/10/28 17:19:25 BTW, I think chrome/common/extensions/api/networki BTW, I think chrome/common/extensions/api/networking_private/networking_private_crypto.cc can be moved into chrome/browser, and then this wouldn't be necessary anymore. Maybe in a follow up CL? tfarina 2016/10/28 18:39:50 I will look in a follow up. Show quoted text On 2016/10/28 17:19:25, Lei Zhang wrote: > BTW, I think > chrome/common/extensions/api/networking_private/networking_private_crypto.cc can > be moved into chrome/browser, and then this wouldn't be necessary anymore. Maybe > in a follow up CL? I will look in a follow up.
36 "+third_party/kasko",	37 "+third_party/kasko",

37	38

38 # FIXME - refactor code and remove these dependencies	39 # FIXME - refactor code and remove these dependencies

39 "+chrome/installer",	40 "+chrome/installer",

40 ]	41 ]

OLD	NEW