Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Unified Diff: components/translate/core/browser/language_model_unittest.cc

Issue 2449873003: [NTP Snippets] Another round of clang-tidy cleanups (Closed)
Patch Set: rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/translate/core/browser/language_model.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/translate/core/browser/language_model_unittest.cc
diff --git a/components/translate/core/browser/language_model_unittest.cc b/components/translate/core/browser/language_model_unittest.cc
index e20a22ceeb5ef119a66f8e4a71d0e90c93103dfe..df8b6bad29de2f8b510d0115d36a8e08fec27348 100644
--- a/components/translate/core/browser/language_model_unittest.cc
+++ b/components/translate/core/browser/language_model_unittest.cc
@@ -22,6 +22,11 @@ const char kLang3[] = "es";
namespace translate {
+bool operator==(const LanguageModel::LanguageInfo& lhs,
+ const LanguageModel::LanguageInfo& rhs) {
+ return lhs.language_code == rhs.language_code;
+}
+
TEST(LanguageModelTest, ListSorted) {
TestingPrefServiceSimple prefs;
LanguageModel::RegisterProfilePrefs(prefs.registry());
@@ -34,9 +39,11 @@ TEST(LanguageModelTest, ListSorted) {
model.OnPageVisited(kLang2);
}
+ // Note: LanguageInfo's operator== only checks the language code, not the
+ // frequency.
EXPECT_THAT(model.GetTopLanguages(),
- ElementsAre(LanguageModel::LanguageInfo{kLang1},
- LanguageModel::LanguageInfo{kLang2}));
+ ElementsAre(LanguageModel::LanguageInfo(kLang1, 0.0f),
+ LanguageModel::LanguageInfo(kLang2, 0.0f)));
}
TEST(LanguageModelTest, ListSortedReversed) {
@@ -51,9 +58,11 @@ TEST(LanguageModelTest, ListSortedReversed) {
model.OnPageVisited(kLang1);
}
+ // Note: LanguageInfo's operator== only checks the language code, not the
+ // frequency.
EXPECT_THAT(model.GetTopLanguages(),
- ElementsAre(LanguageModel::LanguageInfo{kLang1},
- LanguageModel::LanguageInfo{kLang2}));
+ ElementsAre(LanguageModel::LanguageInfo(kLang1, 0.0f),
+ LanguageModel::LanguageInfo(kLang2, 0.0f)));
}
TEST(LanguageModelTest, RightFrequencies) {
« no previous file with comments | « components/translate/core/browser/language_model.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698