Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1703)

Unified Diff: appengine/findit/model/crash/crash_analysis.py

Issue 2449853012: [Predator] Fix bug in min_distance after refactor and add back skip added/deleted deps. (Closed)
Patch Set: Rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/findit/crash/test/findit_for_chromecrash_test.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/model/crash/crash_analysis.py
diff --git a/appengine/findit/model/crash/crash_analysis.py b/appengine/findit/model/crash/crash_analysis.py
index c91fc7fddcb2078f79cf4e346819c22d8a8ab6bb..30f99a74d4ad61613b7b9236770d3872bcb08373 100644
--- a/appengine/findit/model/crash/crash_analysis.py
+++ b/appengine/findit/model/crash/crash_analysis.py
@@ -158,7 +158,7 @@ class CrashAnalysis(ndb.Model):
def ToPublishableResult(self, crash_identifiers):
"""Convert this datastore analysis into a publishable result.
-
+
Args:
crash_identifiers (dict): ??
@@ -174,7 +174,7 @@ class CrashAnalysis(ndb.Model):
client_id == CrashClient.CRACAS):
result['feedback_url'] = _FINDIT_FRACAS_FEEDBACK_URL_TEMPLATE % (
appengine_util.GetDefaultVersionHostname(), self.key.urlsafe())
- if result['found']:
+ if result['found'] and 'suspected_cls' in result:
for cl in result['suspected_cls']:
cl['confidence'] = round(cl['confidence'], 2)
cl.pop('reason', None)
@@ -182,6 +182,8 @@ class CrashAnalysis(ndb.Model):
# TODO(katesonia): Post process clusterfuzz model result if needed.
pass
+ logging.info('Publish result:\n%s',
+ json.dumps(result, indent=4, sort_keys=True))
return {
'crash_identifiers': crash_identifiers,
'client_id': client_id,
« no previous file with comments | « appengine/findit/crash/test/findit_for_chromecrash_test.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698