Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Unified Diff: appengine/findit/crash/scorers/min_distance.py

Issue 2449853012: [Predator] Fix bug in min_distance after refactor and add back skip added/deleted deps. (Closed)
Patch Set: Rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/findit/crash/culprit.py ('k') | appengine/findit/crash/scorers/test/aggregated_scorer_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/crash/scorers/min_distance.py
diff --git a/appengine/findit/crash/scorers/min_distance.py b/appengine/findit/crash/scorers/min_distance.py
index c2e0cd164fb0a3b0d0cc3232cbefa916cd9e89ae..1c2f52137ecee961382504a04f553c3592fd2411 100644
--- a/appengine/findit/crash/scorers/min_distance.py
+++ b/appengine/findit/crash/scorers/min_distance.py
@@ -24,7 +24,7 @@ class MinDistance(Scorer):
def GetMetric(self, result):
min_distance = float('inf')
for analysis_info in result.file_to_analysis_info.itervalues():
- min_distance = min(min_distance, analysis_info['min_distance'])
+ min_distance = min(min_distance, analysis_info.min_distance)
return min_distance
@@ -64,18 +64,18 @@ class MinDistance(Scorer):
for file_path, analysis_info in result.file_to_analysis_info.iteritems():
file_name = file_path.split('/')[-1]
- frame = analysis_info['min_distance_frame']
+ frame = analysis_info.min_distance_frame
# It is possible that a changelog doesn't show in the blame of a file,
# in this case, treat the changelog as if it didn't change the file.
- if analysis_info['min_distance'] == float('inf'):
+ if analysis_info.min_distance == float('inf'):
continue
index_to_changed_files[frame.index] = {
'file': file_name,
'blame_url': frame.BlameUrl(result.changelog.revision),
'info': 'Minimum distance (LOC) %d, frame #%d' % (
- analysis_info['min_distance'], frame.index)
+ analysis_info.min_distance, frame.index)
}
# Sort changed file by frame index.
« no previous file with comments | « appengine/findit/crash/culprit.py ('k') | appengine/findit/crash/scorers/test/aggregated_scorer_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698