Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Issue 2449853010: Revert of [heap] Concurrent store buffer processing. (Closed)

Created:
4 years, 1 month ago by Michael Achenbach
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Concurrent store buffer processing. (patchset #13 id:260001 of https://codereview.chromium.org/2453673003/ ) Reason for revert: Seems to block rolling: https://codereview.chromium.org/2447393005/ Original issue's description: > [heap] Concurrent store buffer processing. > > BUG=chromium:648973, chromium:648568 TBR=ulan@chromium.org,mlippautz@chromium.org,hpayer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:648973, chromium:648568 Committed: https://crrev.com/d800644c0f514f8ae087282fd20acdb84d7eee9a Cr-Commit-Position: refs/heads/master@{#40650}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -199 lines) Patch
M src/heap/heap.cc View 3 chunks +6 lines, -14 lines 0 comments Download
M src/heap/store-buffer.h View 3 chunks +5 lines, -87 lines 0 comments Download
M src/heap/store-buffer.cc View 1 chunk +25 lines, -98 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Achenbach
Created Revert of [heap] Concurrent store buffer processing.
4 years, 1 month ago (2016-10-28 16:45:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2449853010/1
4 years, 1 month ago (2016-10-28 16:45:22 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-28 16:45:36 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:16:59 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d800644c0f514f8ae087282fd20acdb84d7eee9a
Cr-Commit-Position: refs/heads/master@{#40650}

Powered by Google App Engine
This is Rietveld 408576698