Determine the Win10-specific Welcome page variant to display

chrome/browser/ui/webui/welcome_win10_ui.cc

Index: chrome/browser/ui/webui/welcome_win10_ui.cc
diff --git a/chrome/browser/ui/webui/welcome_win10_ui.cc b/chrome/browser/ui/webui/welcome_win10_ui.cc
index bf8c85032098fe9f57f383b9b9c010b4eb4ce22c..51d5e0ab88d79a21adb53ce054e754de2c31c285 100644
--- a/chrome/browser/ui/webui/welcome_win10_ui.cc
+++ b/chrome/browser/ui/webui/welcome_win10_ui.cc
@@ -6,6 +6,7 @@
 
 #include <string>
 
+#include "base/feature_list.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/webui/welcome_win10_handler.h"
 #include "chrome/common/url_constants.h"
@@ -31,6 +32,19 @@ bool UrlContainsKeyValueInQuery(const GURL& url,
          value == expected_value;
 }
 
+bool ShouldShouldInlineStyleVariant(const GURL& url) {

[tmartino, 2016/10/28 15:18:04]

ShouldShould -> ShouldShow?

[Patrick Monette, 2016/10/28 21:21:37]

Done.

+  constexpr base::Feature kWelcomeWin10InlineStyle{

[tmartino, 2016/10/28 15:18:04]

Let's put this (and any other variations/experiments/etc. relating to
startup/first run) in
https://cs.chromium.org/chromium/src/chrome/browser/ui/startup/startup_featur...

I made it just for this :)

[Patrick Monette, 2016/10/28 21:21:37]

Done.

+      "WelcomeWin10InlineStyle", base::FEATURE_DISABLED_BY_DEFAULT};
+
+  // Can be overridden via a query.
+  if (UrlContainsKeyValueInQuery(url, "style", "inline"))
+    return true;
+  if (UrlContainsKeyValueInQuery(url, "style", "sectioned"))
+    return false;
+
+  return base::FeatureList::IsEnabled(kWelcomeWin10InlineStyle);
+}
+
 // Adds all the needed localized strings to |html_source|, depending on
 // the value of |is_first_run|.
 void AddLocalizedStrings(content::WebUIDataSource* html_source,
@@ -82,7 +96,7 @@ WelcomeWin10UI::WelcomeWin10UI(content::WebUI* web_ui, const GURL& url)
 
   // Determine which variation to show.
   bool is_first_run = !UrlContainsKeyValueInQuery(url, "text", "faster");
-  bool is_inline_style = UrlContainsKeyValueInQuery(url, "style", "inline");
+  bool is_inline_style = ShouldShouldInlineStyleVariant(url);
 
   AddLocalizedStrings(html_source, is_first_run);