Determine the Win10-specific Welcome page variant to display

chrome/browser/resources/welcome/win10/inline.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('inline', function() {
   'use strict';
 
+  function computeClasses(isCombined) {
+    if (isCombined)
+      return 'section expandable expanded';
+    return 'section';
+  }
+
   function onContinue() {
     chrome.send('handleContinue');
   }
 
   function onOpenSettings() {
     chrome.send('handleSetDefaultBrowser');
   }
 
   function onToggle(app) {
     if (app.isCombined) {
       var sections = document.querySelectorAll('.section.expandable');
       sections.forEach(function(section) {
         section.classList.toggle('expanded');
       });
     }
   }
 
-  function computeClasses(isCombined) {
-    if (isCombined)
-      return 'section expandable expanded';
-    return 'section';
-  }
-
   function initialize() {
     var app = $('inline-app');
 
-    app.isCombined = window.location.href.includes('variant=combined');
+    // Set variables.
+    // Determines if the combined variant should be displayed. The combined
+    // variant includes instructions on how to pin Chrome to the taskbar.
+    app.isCombined = false;
 
     // Set handlers.
     app.computeClasses = computeClasses;
     app.onContinue = onContinue;
     app.onOpenSettings = onOpenSettings;
     app.onToggle = onToggle.bind(this, app);
+
+    // Asynchronously check if Chrome is pinned to the taskbar.
+    cr.sendWithPromise('getPinnedToTaskbarState').then(
+      function(isPinnedToTaskbar) {
+        // Allow overriding of the result via a query parameter.
+        // TODO(pmonette): Remove these checks when they are no longer needed.
+        var params = new URLSearchParams(location.search.slice(1));
+        if (params.has('variant')) {

[michaelpg, 2016/11/07 03:29:14]

also, making this key a constant would be cool. bonus point for making the
values an "enum" e.g.
https://cs.chromium.org/search/?q=@enum+file:chrome/browser/resources/.*%5C.j...

[Patrick Monette, 2016/11/07 19:55:35]

You got me at "bonus point".

+          if (params.get('variant') === 'defaultonly')
+            app.isCombined = false;
+          if (params.get('variant') === 'combined')

[michaelpg, 2016/11/04 23:59:24]

nit: else if

[Patrick Monette, 2016/11/07 19:55:35]

Done.

+            app.isCombined = true;
+        } else {
+          app.isCombined = !isPinnedToTaskbar;
+        }
+      });
   }
 
   return {
     initialize: initialize
   };
 });
 
 document.addEventListener('DOMContentLoaded', inline.initialize);