Getting rid of DelegatedFrameData

cc/surfaces/display.cc

Index: cc/surfaces/display.cc
diff --git a/cc/surfaces/display.cc b/cc/surfaces/display.cc
index 30700f8b8afeccad862447c85a31f3c2292dfb9c..e0b0439ee7333b6d76e5ad438cc50b80d076da47 100644
--- a/cc/surfaces/display.cc
+++ b/cc/surfaces/display.cc
@@ -214,8 +214,7 @@ void Display::InitializeRenderer() {
 
 void Display::UpdateRootSurfaceResourcesLocked() {
   Surface* surface = surface_manager_->GetSurfaceForId(current_surface_id_);
-  bool root_surface_resources_locked =
-      !surface || !surface->GetEligibleFrame().delegated_frame_data;
+  bool root_surface_resources_locked = !surface || !surface->HasFrame();

[Fady Samuel, 2016/11/16 00:38:23]

I think the right check here is:

root_surface_resources_locked = !surface || !surface->HasFrame() ||
surface->GetEligibleFrame().render_pass_list.empty();

[danakj, 2016/11/16 01:23:17]

Why? The old code did not check for an empty render_pass_list.

[Saman Sami, 2016/11/16 01:40:26]

It didn't explicitly, what we believe it meant to check for it. Could you take a
look at John's comment here:
https://bugs.chromium.org/p/chromium/issues/detail?id=663516#c12

[danakj, 2016/11/16 01:56:17]

I see, this should be false if an empty frame was submitted to reclaim
resources?

This is because ForceReclaimResources() now has to way to submit a "null" frame
and is submitting an "empty" frame instead? Perhaps it should be doing something
else that would cause HasFrame to return false.

   if (scheduler_)
     scheduler_->SetRootSurfaceResourcesLocked(root_surface_resources_locked);
 }
@@ -242,7 +241,8 @@ bool Display::DrawAndSwap() {
   }
 
   CompositorFrame frame = aggregator_->Aggregate(current_surface_id_);
-  if (!frame.delegated_frame_data) {
+
+  if (frame.render_pass_list.empty()) {
     TRACE_EVENT_INSTANT0("cc", "Empty aggregated frame.",
                          TRACE_EVENT_SCOPE_THREAD);
     return false;
@@ -255,21 +255,19 @@ bool Display::DrawAndSwap() {
       surface->RunDrawCallbacks();
   }
 
-  DelegatedFrameData* frame_data = frame.delegated_frame_data.get();
-
   frame.metadata.latency_info.insert(frame.metadata.latency_info.end(),
                                      stored_latency_info_.begin(),
                                      stored_latency_info_.end());
   stored_latency_info_.clear();
   bool have_copy_requests = false;
-  for (const auto& pass : frame_data->render_pass_list) {
+  for (const auto& pass : frame.render_pass_list) {
     have_copy_requests |= !pass->copy_requests.empty();
   }
 
   gfx::Size surface_size;
   bool have_damage = false;
-  if (!frame_data->render_pass_list.empty()) {
-    RenderPass& last_render_pass = *frame_data->render_pass_list.back();
+  if (!frame.render_pass_list.empty()) {
+    RenderPass& last_render_pass = *frame.render_pass_list.back();
     if (last_render_pass.output_rect.size() != current_surface_size_ &&
         last_render_pass.damage_rect == last_render_pass.output_rect &&
         !current_surface_size_.IsEmpty()) {
@@ -296,7 +294,7 @@ bool Display::DrawAndSwap() {
     should_draw = false;
   }
 
-  client_->DisplayWillDrawAndSwap(should_draw, frame_data->render_pass_list);
+  client_->DisplayWillDrawAndSwap(should_draw, frame.render_pass_list);
 
   if (should_draw) {
     bool disable_image_filtering =
@@ -309,9 +307,8 @@ bool Display::DrawAndSwap() {
       DCHECK(!disable_image_filtering);
     }
 
-    renderer_->DecideRenderPassAllocationsForFrame(
-        frame_data->render_pass_list);
-    renderer_->DrawFrame(&frame_data->render_pass_list, device_scale_factor_,
+    renderer_->DecideRenderPassAllocationsForFrame(frame.render_pass_list);
+    renderer_->DrawFrame(&frame.render_pass_list, device_scale_factor_,
                          device_color_space_, current_surface_size_);
   } else {
     TRACE_EVENT_INSTANT0("cc", "Draw skipped.", TRACE_EVENT_SCOPE_THREAD);
@@ -372,9 +369,8 @@ void Display::OnSurfaceDamaged(const SurfaceId& surface_id, bool* changed) {
       aggregator_->previous_contained_surfaces().count(surface_id)) {
     Surface* surface = surface_manager_->GetSurfaceForId(surface_id);
     if (surface) {
-      const CompositorFrame& current_frame = surface->GetEligibleFrame();
-      if (!current_frame.delegated_frame_data ||
-          current_frame.delegated_frame_data->resource_list.empty()) {
+      if (!surface->HasFrame() ||
+          surface->GetEligibleFrame().resource_list.empty()) {
         aggregator_->ReleaseResources(surface_id);
       }
     }