cc/output/compositor_frame.cc - Issue 2449853004: Getting rid of DelegatedFrameData

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/output/compositor_frame.cc

Issue 2449853004: Getting rid of DelegatedFrameData (Closed)

Patch Set: Addressed reviewers' concerns Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/output/compositor_frame.cc

diff --git a/cc/output/compositor_frame.cc b/cc/output/compositor_frame.cc

index 82479cf3b43ab363fb4cd1b458754f10e8da1429..2ca1efea588320eb480e4986062d82434858105b 100644

--- a/cc/output/compositor_frame.cc

+++ b/cc/output/compositor_frame.cc

@@ -14,4 +14,9 @@ CompositorFrame::~CompositorFrame() {}

CompositorFrame& CompositorFrame::operator=(CompositorFrame&& other) = default;

+bool CompositorFrame::IsEmpty() const {

+ DCHECK(resource_list.empty() == render_pass_list.empty());

Fady Samuel 2016/10/26 16:17:41 This DCHECK is wrong: DCHECK(resource_list.empty(

+ return render_pass_list.empty();

} // namespace cc

« no previous file with comments | « cc/output/compositor_frame.h ('k') | cc/output/delegated_frame_data.h » ('j') | no next file with comments »