Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1655)

Unified Diff: content/renderer/android/synchronous_compositor_frame_sink.cc

Issue 2449853004: Getting rid of DelegatedFrameData (Closed)
Patch Set: IsEmpty + rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/android/synchronous_compositor_frame_sink.cc
diff --git a/content/renderer/android/synchronous_compositor_frame_sink.cc b/content/renderer/android/synchronous_compositor_frame_sink.cc
index 32b07eb2bc472d8cc1e749c65781fc5213847b69..fdfe9786053ab1a03cf9e9c82fe908595a1e1520 100644
--- a/content/renderer/android/synchronous_compositor_frame_sink.cc
+++ b/content/renderer/android/synchronous_compositor_frame_sink.cc
@@ -218,7 +218,7 @@ void SynchronousCompositorFrameSink::SubmitCompositorFrame(
DCHECK(sync_client_);
if (fallback_tick_running_) {
- DCHECK(frame.delegated_frame_data->resource_list.empty());
+ DCHECK(frame.resource_list.empty());
cc::ReturnedResourceArray return_resources;
ReturnResources(return_resources);
did_submit_frame_ = true;
@@ -245,8 +245,7 @@ void SynchronousCompositorFrameSink::SubmitCompositorFrame(
// The layer compositor should be giving a frame that covers the
// |sw_viewport_for_current_draw_| but at 0,0.
gfx::Size child_size = sw_viewport_for_current_draw_.size();
- DCHECK(gfx::Rect(child_size) ==
- frame.delegated_frame_data->render_pass_list.back()->output_rect);
+ DCHECK(gfx::Rect(child_size) == frame.render_pass_list.back()->output_rect);
// Make a size that covers from 0,0 and includes the area coming from the
// layer compositor.
@@ -266,14 +265,10 @@ void SynchronousCompositorFrameSink::SubmitCompositorFrame(
// the CompositorFrameSink client too? (We'd have to do the same for
// hardware frames in SurfacesInstance?)
cc::CompositorFrame embed_frame;
- embed_frame.delegated_frame_data =
- base::MakeUnique<cc::DelegatedFrameData>();
- embed_frame.delegated_frame_data->render_pass_list.push_back(
- cc::RenderPass::Create());
+ embed_frame.render_pass_list.push_back(cc::RenderPass::Create());
// The embedding RenderPass covers the entire Display's area.
- const auto& embed_render_pass =
- embed_frame.delegated_frame_data->render_pass_list.back();
+ const auto& embed_render_pass = embed_frame.render_pass_list.back();
embed_render_pass->SetAll(cc::RenderPassId(1, 1), gfx::Rect(display_size),
gfx::Rect(display_size), gfx::Transform(), false);

Powered by Google App Engine
This is Rietveld 408576698