third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp - Issue 2449853004: Getting rid of DelegatedFrameData

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp

Issue 2449853004: Getting rid of DelegatedFrameData (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/render_widget_host_view_mac.mm ('K') | « services/ui/ws/window_tree_client_unittest.cc ('k') | tools/ipc_fuzzer/fuzzer/fuzzer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp b/third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp

index 948b02956d439adbfc501e2932c0246d4d1f8337..65292a0f89a7981bb788e2aa70bd88768fdbded5 100644

--- a/third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp

+++ b/third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp

@@ -157,7 +157,6 @@ void OffscreenCanvasFrameDispatcherImpl::dispatchFrame(

cc::CompositorFrame frame;

// TODO(crbug.com/652931): update the device_scale_factor

frame.metadata.device_scale_factor = 1.0f;

- frame.delegated_frame_data.reset(new cc::DelegatedFrameData);

const gfx::Rect bounds(m_width, m_height);

const cc::RenderPassId renderPassId(1, 1);

@@ -214,7 +213,7 @@ void OffscreenCanvasFrameDispatcherImpl::dispatchFrame(

commitTypeHistogram.count(commitType);

m_nextResourceId++;

- frame.delegated_frame_data->resource_list.push_back(std::move(resource));

+ frame.resource_list.push_back(std::move(resource));

cc::TextureDrawQuad* quad =

pass->CreateAndAppendDrawQuad<cc::TextureDrawQuad>();

@@ -235,7 +234,7 @@ void OffscreenCanvasFrameDispatcherImpl::dispatchFrame(

SK_ColorTRANSPARENT, vertexOpacity, yflipped, nearestNeighbor,

false);

- frame.delegated_frame_data->render_pass_list.push_back(std::move(pass));

+ frame.render_pass_list.push_back(std::move(pass));

double elapsedTime = WTF::monotonicallyIncreasingTime() - commitStartTime;

switch (commitType) {