Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: content/browser/frame_host/render_widget_host_view_guest_unittest.cc

Issue 2449853004: Getting rid of DelegatedFrameData (Closed)
Patch Set: nit Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/frame_host/render_widget_host_view_guest.h" 5 #include "content/browser/frame_host/render_widget_host_view_guest.h"
6 6
7 #include <stdint.h> 7 #include <stdint.h>
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
(...skipping 230 matching lines...) Expand 10 before | Expand all | Expand 10 after
241 private: 241 private:
242 DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostViewGuestSurfaceTest); 242 DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostViewGuestSurfaceTest);
243 }; 243 };
244 244
245 namespace { 245 namespace {
246 cc::CompositorFrame CreateDelegatedFrame(float scale_factor, 246 cc::CompositorFrame CreateDelegatedFrame(float scale_factor,
247 gfx::Size size, 247 gfx::Size size,
248 const gfx::Rect& damage) { 248 const gfx::Rect& damage) {
249 cc::CompositorFrame frame; 249 cc::CompositorFrame frame;
250 frame.metadata.device_scale_factor = scale_factor; 250 frame.metadata.device_scale_factor = scale_factor;
251 frame.delegated_frame_data.reset(new cc::DelegatedFrameData);
252 251
253 std::unique_ptr<cc::RenderPass> pass = cc::RenderPass::Create(); 252 std::unique_ptr<cc::RenderPass> pass = cc::RenderPass::Create();
254 pass->SetNew(cc::RenderPassId(1, 1), gfx::Rect(size), damage, 253 pass->SetNew(cc::RenderPassId(1, 1), gfx::Rect(size), damage,
255 gfx::Transform()); 254 gfx::Transform());
256 frame.delegated_frame_data->render_pass_list.push_back(std::move(pass)); 255 frame.render_pass_list.push_back(std::move(pass));
257 return frame; 256 return frame;
258 } 257 }
259 } // anonymous namespace 258 } // anonymous namespace
260 259
261 TEST_F(RenderWidgetHostViewGuestSurfaceTest, TestGuestSurface) { 260 TEST_F(RenderWidgetHostViewGuestSurfaceTest, TestGuestSurface) {
262 gfx::Size view_size(100, 100); 261 gfx::Size view_size(100, 100);
263 gfx::Rect view_rect(view_size); 262 gfx::Rect view_rect(view_size);
264 float scale_factor = 1.f; 263 float scale_factor = 1.f;
265 264
266 ASSERT_TRUE(browser_plugin_guest_); 265 ASSERT_TRUE(browser_plugin_guest_);
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
315 314
316 browser_plugin_guest_->set_attached(false); 315 browser_plugin_guest_->set_attached(false);
317 browser_plugin_guest_->ResetTestData(); 316 browser_plugin_guest_->ResetTestData();
318 317
319 view_->OnSwapCompositorFrame( 318 view_->OnSwapCompositorFrame(
320 0, CreateDelegatedFrame(scale_factor, view_size, view_rect)); 319 0, CreateDelegatedFrame(scale_factor, view_size, view_rect));
321 EXPECT_FALSE(GetSurfaceId().is_valid()); 320 EXPECT_FALSE(GetSurfaceId().is_valid());
322 } 321 }
323 322
324 } // namespace content 323 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698