Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Side by Side Diff: components/exo/surface_unittest.cc

Issue 2449853004: Getting rid of DelegatedFrameData (Closed)
Patch Set: nit Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/exo/surface.cc ('k') | content/browser/bad_message.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/bind.h" 5 #include "base/bind.h"
6 #include "cc/output/compositor_frame.h" 6 #include "cc/output/compositor_frame.h"
7 #include "cc/output/delegated_frame_data.h"
8 #include "cc/quads/texture_draw_quad.h" 7 #include "cc/quads/texture_draw_quad.h"
9 #include "cc/surfaces/surface.h" 8 #include "cc/surfaces/surface.h"
10 #include "cc/surfaces/surface_manager.h" 9 #include "cc/surfaces/surface_manager.h"
11 #include "components/exo/buffer.h" 10 #include "components/exo/buffer.h"
12 #include "components/exo/surface.h" 11 #include "components/exo/surface.h"
13 #include "components/exo/test/exo_test_base.h" 12 #include "components/exo/test/exo_test_base.h"
14 #include "components/exo/test/exo_test_helper.h" 13 #include "components/exo/test/exo_test_helper.h"
15 #include "testing/gtest/include/gtest/gtest.h" 14 #include "testing/gtest/include/gtest/gtest.h"
16 #include "ui/aura/env.h" 15 #include "ui/aura/env.h"
17 #include "ui/compositor/layer_tree_owner.h" 16 #include "ui/compositor/layer_tree_owner.h"
(...skipping 163 matching lines...) Expand 10 before | Expand all | Expand 10 after
181 180
182 surface->Attach(buffer.get()); 181 surface->Attach(buffer.get());
183 gfx::Size crop_size(12, 12); 182 gfx::Size crop_size(12, 12);
184 surface->SetCrop(gfx::RectF(gfx::PointF(2.0, 2.0), gfx::SizeF(crop_size))); 183 surface->SetCrop(gfx::RectF(gfx::PointF(2.0, 2.0), gfx::SizeF(crop_size)));
185 surface->Commit(); 184 surface->Commit();
186 EXPECT_EQ(crop_size.ToString(), 185 EXPECT_EQ(crop_size.ToString(),
187 surface->window()->bounds().size().ToString()); 186 surface->window()->bounds().size().ToString());
188 EXPECT_EQ(crop_size.ToString(), surface->content_size().ToString()); 187 EXPECT_EQ(crop_size.ToString(), surface->content_size().ToString());
189 } 188 }
190 189
191 const cc::DelegatedFrameData* GetFrameFromSurface(Surface* surface) { 190 const cc::CompositorFrame& GetFrameFromSurface(Surface* surface) {
192 cc::SurfaceId surface_id = surface->GetSurfaceId(); 191 cc::SurfaceId surface_id = surface->GetSurfaceId();
193 cc::SurfaceManager* surface_manager = 192 cc::SurfaceManager* surface_manager =
194 aura::Env::GetInstance()->context_factory()->GetSurfaceManager(); 193 aura::Env::GetInstance()->context_factory()->GetSurfaceManager();
195 const cc::CompositorFrame& frame = 194 const cc::CompositorFrame& frame =
196 surface_manager->GetSurfaceForId(surface_id)->GetEligibleFrame(); 195 surface_manager->GetSurfaceForId(surface_id)->GetEligibleFrame();
197 return frame.delegated_frame_data.get(); 196 return frame;
198 } 197 }
199 198
200 TEST_F(SurfaceTest, SetBlendMode) { 199 TEST_F(SurfaceTest, SetBlendMode) {
201 gfx::Size buffer_size(1, 1); 200 gfx::Size buffer_size(1, 1);
202 std::unique_ptr<Buffer> buffer( 201 std::unique_ptr<Buffer> buffer(
203 new Buffer(exo_test_helper()->CreateGpuMemoryBuffer(buffer_size))); 202 new Buffer(exo_test_helper()->CreateGpuMemoryBuffer(buffer_size)));
204 std::unique_ptr<Surface> surface(new Surface); 203 std::unique_ptr<Surface> surface(new Surface);
205 204
206 surface->Attach(buffer.get()); 205 surface->Attach(buffer.get());
207 surface->SetBlendMode(SkXfermode::kSrc_Mode); 206 surface->SetBlendMode(SkXfermode::kSrc_Mode);
208 surface->Commit(); 207 surface->Commit();
209 208
210 const cc::DelegatedFrameData* frame_data = GetFrameFromSurface(surface.get()); 209 const cc::CompositorFrame& frame = GetFrameFromSurface(surface.get());
211 ASSERT_EQ(1u, frame_data->render_pass_list.size()); 210 ASSERT_EQ(1u, frame.render_pass_list.size());
212 ASSERT_EQ(1u, frame_data->render_pass_list.back()->quad_list.size()); 211 ASSERT_EQ(1u, frame.render_pass_list.back()->quad_list.size());
213 EXPECT_FALSE(frame_data->render_pass_list.back() 212 EXPECT_FALSE(frame.render_pass_list.back()
214 ->quad_list.back() 213 ->quad_list.back()
215 ->ShouldDrawWithBlending()); 214 ->ShouldDrawWithBlending());
216 } 215 }
217 216
218 TEST_F(SurfaceTest, OverlayCandidate) { 217 TEST_F(SurfaceTest, OverlayCandidate) {
219 gfx::Size buffer_size(1, 1); 218 gfx::Size buffer_size(1, 1);
220 std::unique_ptr<Buffer> buffer(new Buffer( 219 std::unique_ptr<Buffer> buffer(new Buffer(
221 exo_test_helper()->CreateGpuMemoryBuffer(buffer_size), 0, 0, true, true)); 220 exo_test_helper()->CreateGpuMemoryBuffer(buffer_size), 0, 0, true, true));
222 std::unique_ptr<Surface> surface(new Surface); 221 std::unique_ptr<Surface> surface(new Surface);
223 222
224 surface->Attach(buffer.get()); 223 surface->Attach(buffer.get());
225 surface->Commit(); 224 surface->Commit();
226 225
227 const cc::DelegatedFrameData* frame_data = GetFrameFromSurface(surface.get()); 226 const cc::CompositorFrame& frame = GetFrameFromSurface(surface.get());
228 ASSERT_EQ(1u, frame_data->render_pass_list.size()); 227 ASSERT_EQ(1u, frame.render_pass_list.size());
229 ASSERT_EQ(1u, frame_data->render_pass_list.back()->quad_list.size()); 228 ASSERT_EQ(1u, frame.render_pass_list.back()->quad_list.size());
230 cc::DrawQuad* draw_quad = 229 cc::DrawQuad* draw_quad = frame.render_pass_list.back()->quad_list.back();
231 frame_data->render_pass_list.back()->quad_list.back();
232 ASSERT_EQ(cc::DrawQuad::TEXTURE_CONTENT, draw_quad->material); 230 ASSERT_EQ(cc::DrawQuad::TEXTURE_CONTENT, draw_quad->material);
233 231
234 const cc::TextureDrawQuad* texture_quad = 232 const cc::TextureDrawQuad* texture_quad =
235 cc::TextureDrawQuad::MaterialCast(draw_quad); 233 cc::TextureDrawQuad::MaterialCast(draw_quad);
236 EXPECT_FALSE(texture_quad->resource_size_in_pixels().IsEmpty()); 234 EXPECT_FALSE(texture_quad->resource_size_in_pixels().IsEmpty());
237 } 235 }
238 236
239 TEST_F(SurfaceTest, SetAlpha) { 237 TEST_F(SurfaceTest, SetAlpha) {
240 gfx::Size buffer_size(1, 1); 238 gfx::Size buffer_size(1, 1);
241 std::unique_ptr<Buffer> buffer( 239 std::unique_ptr<Buffer> buffer(
242 new Buffer(exo_test_helper()->CreateGpuMemoryBuffer(buffer_size))); 240 new Buffer(exo_test_helper()->CreateGpuMemoryBuffer(buffer_size)));
243 std::unique_ptr<Surface> surface(new Surface); 241 std::unique_ptr<Surface> surface(new Surface);
244 242
245 surface->Attach(buffer.get()); 243 surface->Attach(buffer.get());
246 surface->SetAlpha(0.5f); 244 surface->SetAlpha(0.5f);
247 surface->Commit(); 245 surface->Commit();
248 } 246 }
249 247
250 TEST_F(SurfaceTest, Commit) { 248 TEST_F(SurfaceTest, Commit) {
251 std::unique_ptr<Surface> surface(new Surface); 249 std::unique_ptr<Surface> surface(new Surface);
252 250
253 // Calling commit without a buffer should succeed. 251 // Calling commit without a buffer should succeed.
254 surface->Commit(); 252 surface->Commit();
255 } 253 }
256 254
257 } // namespace 255 } // namespace
258 } // namespace exo 256 } // namespace exo
OLDNEW
« no previous file with comments | « components/exo/surface.cc ('k') | content/browser/bad_message.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698