Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Side by Side Diff: cc/trees/layer_tree_host_unittest.cc

Issue 2449853004: Getting rid of DelegatedFrameData (Closed)
Patch Set: Dana's comment rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2011 The Chromium Authors. All rights reserved. 1 // Copyright 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/trees/layer_tree_host.h" 5 #include "cc/trees/layer_tree_host.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <algorithm> 10 #include <algorithm>
(...skipping 6959 matching lines...) Expand 10 before | Expand all | Expand 10 after
6970 EXPECT_EQ(DRAW_SUCCESS, draw_result); 6970 EXPECT_EQ(DRAW_SUCCESS, draw_result);
6971 EXPECT_EQ(0, num_swaps_); 6971 EXPECT_EQ(0, num_swaps_);
6972 drawn_viewport_ = host_impl->DeviceViewport(); 6972 drawn_viewport_ = host_impl->DeviceViewport();
6973 return draw_result; 6973 return draw_result;
6974 } 6974 }
6975 6975
6976 void DisplayReceivedCompositorFrameOnThread( 6976 void DisplayReceivedCompositorFrameOnThread(
6977 const CompositorFrame& frame) override { 6977 const CompositorFrame& frame) override {
6978 EXPECT_EQ(1, ++num_swaps_); 6978 EXPECT_EQ(1, ++num_swaps_);
6979 6979
6980 DelegatedFrameData* last_frame_data = frame.delegated_frame_data.get(); 6980 EXPECT_EQ(drawn_viewport_, frame.render_pass_list.back()->output_rect);
6981 ASSERT_TRUE(frame.delegated_frame_data);
6982 EXPECT_EQ(drawn_viewport_,
6983 last_frame_data->render_pass_list.back()->output_rect);
6984 EXPECT_EQ(0.5f, frame.metadata.min_page_scale_factor); 6981 EXPECT_EQ(0.5f, frame.metadata.min_page_scale_factor);
6985 EXPECT_EQ(4.f, frame.metadata.max_page_scale_factor); 6982 EXPECT_EQ(4.f, frame.metadata.max_page_scale_factor);
6986 6983
6987 EXPECT_EQ(0u, frame.delegated_frame_data->resource_list.size()); 6984 EXPECT_EQ(0u, frame.resource_list.size());
6988 EXPECT_EQ(1u, frame.delegated_frame_data->render_pass_list.size()); 6985 EXPECT_EQ(1u, frame.render_pass_list.size());
6989 6986
6990 EndTest(); 6987 EndTest();
6991 } 6988 }
6992 6989
6993 void AfterTest() override {} 6990 void AfterTest() override {}
6994 6991
6995 int num_swaps_ = 0; 6992 int num_swaps_ = 0;
6996 gfx::Rect drawn_viewport_; 6993 gfx::Rect drawn_viewport_;
6997 }; 6994 };
6998 6995
(...skipping 17 matching lines...) Expand all
7016 7013
7017 RenderPass* pass = AddRenderPass(&frame->render_passes, RenderPassId(1, 1), 7014 RenderPass* pass = AddRenderPass(&frame->render_passes, RenderPassId(1, 1),
7018 gfx::Rect(3, 3, 10, 10), gfx::Transform()); 7015 gfx::Rect(3, 3, 10, 10), gfx::Transform());
7019 AddOneOfEveryQuadType(pass, host_impl->resource_provider(), child_pass->id, 7016 AddOneOfEveryQuadType(pass, host_impl->resource_provider(), child_pass->id,
7020 &mailbox_sync_token); 7017 &mailbox_sync_token);
7021 return draw_result; 7018 return draw_result;
7022 } 7019 }
7023 7020
7024 void DisplayReceivedCompositorFrameOnThread( 7021 void DisplayReceivedCompositorFrameOnThread(
7025 const CompositorFrame& frame) override { 7022 const CompositorFrame& frame) override {
7026 ASSERT_TRUE(frame.delegated_frame_data); 7023 EXPECT_EQ(2u, frame.render_pass_list.size());
7027
7028 EXPECT_EQ(2u, frame.delegated_frame_data->render_pass_list.size());
7029 // Each render pass has 10 resources in it. And the root render pass has a 7024 // Each render pass has 10 resources in it. And the root render pass has a
7030 // mask resource used when drawing the child render pass. The number 10 may 7025 // mask resource used when drawing the child render pass. The number 10 may
7031 // change if AppendOneOfEveryQuadType() is updated, and the value here 7026 // change if AppendOneOfEveryQuadType() is updated, and the value here
7032 // should be updated accordingly. 7027 // should be updated accordingly.
7033 EXPECT_EQ(21u, frame.delegated_frame_data->resource_list.size()); 7028 EXPECT_EQ(21u, frame.resource_list.size());
7034 7029
7035 EndTest(); 7030 EndTest();
7036 } 7031 }
7037 7032
7038 void AfterTest() override {} 7033 void AfterTest() override {}
7039 }; 7034 };
7040 7035
7041 SINGLE_AND_MULTI_THREAD_TEST_F(LayerTreeHostTestSubmitFrameResources); 7036 SINGLE_AND_MULTI_THREAD_TEST_F(LayerTreeHostTestSubmitFrameResources);
7042 7037
7043 } // namespace 7038 } // namespace
7044 } // namespace cc 7039 } // namespace cc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698