Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Side by Side Diff: cc/ipc/cc_param_traits_unittest.cc

Issue 2449853004: Getting rid of DelegatedFrameData (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stddef.h> 5 #include <stddef.h>
6 #include <string.h> 6 #include <string.h>
7 #include <algorithm> 7 #include <algorithm>
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
11 #include "build/build_config.h" 11 #include "build/build_config.h"
12 #include "cc/ipc/cc_param_traits.h" 12 #include "cc/ipc/cc_param_traits.h"
13 #include "cc/output/compositor_frame.h" 13 #include "cc/output/compositor_frame.h"
14 #include "cc/quads/picture_draw_quad.h" 14 #include "cc/quads/picture_draw_quad.h"
15 #include "cc/quads/render_pass_draw_quad.h" 15 #include "cc/quads/render_pass_draw_quad.h"
16 #include "ipc/ipc_message.h" 16 #include "ipc/ipc_message.h"
17 #include "testing/gtest/include/gtest/gtest.h" 17 #include "testing/gtest/include/gtest/gtest.h"
18 #include "third_party/skia/include/effects/SkBlurImageFilter.h" 18 #include "third_party/skia/include/effects/SkBlurImageFilter.h"
19 19
20 #if defined(OS_POSIX) 20 #if defined(OS_POSIX)
21 #include "base/file_descriptor_posix.h" 21 #include "base/file_descriptor_posix.h"
22 #endif 22 #endif
23 23
24 using cc::DelegatedFrameData; 24 using cc::CompositorFrame;
25 using cc::DebugBorderDrawQuad; 25 using cc::DebugBorderDrawQuad;
26 using cc::DrawQuad; 26 using cc::DrawQuad;
27 using cc::FilterOperation; 27 using cc::FilterOperation;
28 using cc::FilterOperations; 28 using cc::FilterOperations;
29 using cc::PictureDrawQuad; 29 using cc::PictureDrawQuad;
30 using cc::RenderPass; 30 using cc::RenderPass;
31 using cc::RenderPassId; 31 using cc::RenderPassId;
32 using cc::RenderPassDrawQuad; 32 using cc::RenderPassDrawQuad;
33 using cc::ResourceId; 33 using cc::ResourceId;
34 using cc::ResourceProvider; 34 using cc::ResourceProvider;
(...skipping 388 matching lines...) Expand 10 before | Expand all | Expand 10 after
423 for (size_t i = 1; i < pass_in->quad_list.size(); ++i) { 423 for (size_t i = 1; i < pass_in->quad_list.size(); ++i) {
424 bool same_shared_quad_state_cmp = 424 bool same_shared_quad_state_cmp =
425 pass_cmp->quad_list.ElementAt(i)->shared_quad_state == 425 pass_cmp->quad_list.ElementAt(i)->shared_quad_state ==
426 pass_cmp->quad_list.ElementAt(i - 1)->shared_quad_state; 426 pass_cmp->quad_list.ElementAt(i - 1)->shared_quad_state;
427 bool same_shared_quad_state_in = 427 bool same_shared_quad_state_in =
428 pass_in->quad_list.ElementAt(i)->shared_quad_state == 428 pass_in->quad_list.ElementAt(i)->shared_quad_state ==
429 pass_in->quad_list.ElementAt(i - 1)->shared_quad_state; 429 pass_in->quad_list.ElementAt(i - 1)->shared_quad_state;
430 EXPECT_EQ(same_shared_quad_state_cmp, same_shared_quad_state_in); 430 EXPECT_EQ(same_shared_quad_state_cmp, same_shared_quad_state_in);
431 } 431 }
432 432
433 DelegatedFrameData frame_in; 433 CompositorFrame frame_in;
434 frame_in.render_pass_list.push_back(std::move(child_pass_in)); 434 frame_in.render_pass_list.push_back(std::move(child_pass_in));
435 frame_in.render_pass_list.push_back(std::move(pass_in)); 435 frame_in.render_pass_list.push_back(std::move(pass_in));
436 436
437 IPC::ParamTraits<DelegatedFrameData>::Write(&msg, frame_in); 437 IPC::ParamTraits<CompositorFrame>::Write(&msg, frame_in);
438 438
439 DelegatedFrameData frame_out; 439 CompositorFrame frame_out;
440 base::PickleIterator iter(msg); 440 base::PickleIterator iter(msg);
441 EXPECT_TRUE( 441 EXPECT_TRUE(IPC::ParamTraits<CompositorFrame>::Read(&msg, &iter, &frame_out));
442 IPC::ParamTraits<DelegatedFrameData>::Read(&msg, &iter, &frame_out));
443 442
444 // Make sure the out and cmp RenderPasses match. 443 // Make sure the out and cmp RenderPasses match.
445 std::unique_ptr<RenderPass> child_pass_out = 444 std::unique_ptr<RenderPass> child_pass_out =
446 std::move(frame_out.render_pass_list[0]); 445 std::move(frame_out.render_pass_list[0]);
447 Compare(child_pass_cmp.get(), child_pass_out.get()); 446 Compare(child_pass_cmp.get(), child_pass_out.get());
448 ASSERT_EQ(0u, child_pass_out->shared_quad_state_list.size()); 447 ASSERT_EQ(0u, child_pass_out->shared_quad_state_list.size());
449 ASSERT_EQ(0u, child_pass_out->quad_list.size()); 448 ASSERT_EQ(0u, child_pass_out->quad_list.size());
450 std::unique_ptr<RenderPass> pass_out = 449 std::unique_ptr<RenderPass> pass_out =
451 std::move(frame_out.render_pass_list[1]); 450 std::move(frame_out.render_pass_list[1]);
452 Compare(pass_cmp.get(), pass_out.get()); 451 Compare(pass_cmp.get(), pass_out.get());
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
516 // The fifth is not used again. 515 // The fifth is not used again.
517 SharedQuadState* shared_state5_in = pass_in->CreateAndAppendSharedQuadState(); 516 SharedQuadState* shared_state5_in = pass_in->CreateAndAppendSharedQuadState();
518 shared_state5_in->SetAll(gfx::Transform(), gfx::Size(5, 5), gfx::Rect(), 517 shared_state5_in->SetAll(gfx::Transform(), gfx::Size(5, 5), gfx::Rect(),
519 gfx::Rect(), false, 1.f, SkXfermode::kSrcOver_Mode, 518 gfx::Rect(), false, 1.f, SkXfermode::kSrcOver_Mode,
520 0); 519 0);
521 520
522 // 5 SharedQuadStates go in. 521 // 5 SharedQuadStates go in.
523 ASSERT_EQ(5u, pass_in->shared_quad_state_list.size()); 522 ASSERT_EQ(5u, pass_in->shared_quad_state_list.size());
524 ASSERT_EQ(2u, pass_in->quad_list.size()); 523 ASSERT_EQ(2u, pass_in->quad_list.size());
525 524
526 DelegatedFrameData frame_in; 525 CompositorFrame frame_in;
527 frame_in.render_pass_list.push_back(std::move(pass_in)); 526 frame_in.render_pass_list.push_back(std::move(pass_in));
528 527
529 IPC::Message msg(1, 2, IPC::Message::PRIORITY_NORMAL); 528 IPC::Message msg(1, 2, IPC::Message::PRIORITY_NORMAL);
530 IPC::ParamTraits<DelegatedFrameData>::Write(&msg, frame_in); 529 IPC::ParamTraits<CompositorFrame>::Write(&msg, frame_in);
531 530
532 DelegatedFrameData frame_out; 531 CompositorFrame frame_out;
533 base::PickleIterator iter(msg); 532 base::PickleIterator iter(msg);
534 EXPECT_TRUE( 533 EXPECT_TRUE(IPC::ParamTraits<CompositorFrame>::Read(&msg, &iter, &frame_out));
535 IPC::ParamTraits<DelegatedFrameData>::Read(&msg, &iter, &frame_out));
536 534
537 std::unique_ptr<RenderPass> pass_out = 535 std::unique_ptr<RenderPass> pass_out =
538 std::move(frame_out.render_pass_list[0]); 536 std::move(frame_out.render_pass_list[0]);
539 537
540 // 2 SharedQuadStates come out. The first and fourth SharedQuadStates were 538 // 2 SharedQuadStates come out. The first and fourth SharedQuadStates were
541 // used by quads, and so serialized. Others were not. 539 // used by quads, and so serialized. Others were not.
542 ASSERT_EQ(2u, pass_out->shared_quad_state_list.size()); 540 ASSERT_EQ(2u, pass_out->shared_quad_state_list.size());
543 ASSERT_EQ(2u, pass_out->quad_list.size()); 541 ASSERT_EQ(2u, pass_out->quad_list.size());
544 542
545 EXPECT_EQ(gfx::Size(1, 1).ToString(), 543 EXPECT_EQ(gfx::Size(1, 1).ToString(),
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
589 arbitrary_resource2.size = gfx::Size(89123, 23789); 587 arbitrary_resource2.size = gfx::Size(89123, 23789);
590 arbitrary_resource2.mailbox_holder.mailbox.SetName(arbitrary_mailbox2); 588 arbitrary_resource2.mailbox_holder.mailbox.SetName(arbitrary_mailbox2);
591 arbitrary_resource2.mailbox_holder.texture_target = GL_TEXTURE_EXTERNAL_OES; 589 arbitrary_resource2.mailbox_holder.texture_target = GL_TEXTURE_EXTERNAL_OES;
592 arbitrary_resource2.mailbox_holder.sync_token = arbitrary_token2; 590 arbitrary_resource2.mailbox_holder.sync_token = arbitrary_token2;
593 arbitrary_resource2.is_overlay_candidate = false; 591 arbitrary_resource2.is_overlay_candidate = false;
594 592
595 std::unique_ptr<RenderPass> renderpass_in = RenderPass::Create(); 593 std::unique_ptr<RenderPass> renderpass_in = RenderPass::Create();
596 renderpass_in->SetNew(RenderPassId(1, 1), gfx::Rect(), gfx::Rect(), 594 renderpass_in->SetNew(RenderPassId(1, 1), gfx::Rect(), gfx::Rect(),
597 gfx::Transform()); 595 gfx::Transform());
598 596
599 DelegatedFrameData frame_in; 597 CompositorFrame frame_in;
600 frame_in.resource_list.push_back(arbitrary_resource1); 598 frame_in.resource_list.push_back(arbitrary_resource1);
601 frame_in.resource_list.push_back(arbitrary_resource2); 599 frame_in.resource_list.push_back(arbitrary_resource2);
602 frame_in.render_pass_list.push_back(std::move(renderpass_in)); 600 frame_in.render_pass_list.push_back(std::move(renderpass_in));
603 601
604 IPC::ParamTraits<DelegatedFrameData>::Write(&msg, frame_in); 602 IPC::ParamTraits<CompositorFrame>::Write(&msg, frame_in);
605 603
606 DelegatedFrameData frame_out; 604 CompositorFrame frame_out;
607 base::PickleIterator iter(msg); 605 base::PickleIterator iter(msg);
608 EXPECT_TRUE( 606 EXPECT_TRUE(IPC::ParamTraits<CompositorFrame>::Read(&msg, &iter, &frame_out));
609 IPC::ParamTraits<DelegatedFrameData>::Read(&msg, &iter, &frame_out));
610 607
611 ASSERT_EQ(2u, frame_out.resource_list.size()); 608 ASSERT_EQ(2u, frame_out.resource_list.size());
612 Compare(arbitrary_resource1, frame_out.resource_list[0]); 609 Compare(arbitrary_resource1, frame_out.resource_list[0]);
613 Compare(arbitrary_resource2, frame_out.resource_list[1]); 610 Compare(arbitrary_resource2, frame_out.resource_list[1]);
614 } 611 }
615 612
616 } // namespace 613 } // namespace
617 } // namespace content 614 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698