Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 2449783006: Add a native data property that replaces itself with a real data property (Closed)

Created:
4 years, 1 month ago by jochen (gone - plz use gerrit)
Modified:
4 years, 1 month ago
Reviewers:
haraken, Toon Verwaest
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add a native data property that replaces itself with a real data property This is useful for things that don't ever change, but we don't want to eagerly compute the result. Doing this from the embedder is difficult, using DefineOwnProperty would read the property to get the property descriptor, creating an endless recursion. R=verwaest@chromium.org,haraken@chromium.org BUG= Committed: https://crrev.com/f07421508221dfcca43a6c10ad8e9047f8f8fcdf Cr-Commit-Position: refs/heads/master@{#40648}

Patch Set 1 #

Total comments: 1

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -14 lines) Patch
M include/v8.h View 1 1 chunk +8 lines, -0 lines 0 comments Download
M src/accessors.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/api.cc View 1 8 chunks +25 lines, -11 lines 0 comments Download
M src/objects.h View 1 2 chunks +5 lines, -1 line 0 comments Download
M src/objects.cc View 1 1 chunk +8 lines, -2 lines 0 comments Download
M src/objects-inl.h View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (11 generated)
jochen (gone - plz use gerrit)
wdyt? we could use this for the v8ConstructorMethodGetter in blink
4 years, 1 month ago (2016-10-27 11:02:21 UTC) #3
Toon Verwaest
Huh? That's the default setter behavior for special data properties?
4 years, 1 month ago (2016-10-27 12:19:32 UTC) #6
jochen (gone - plz use gerrit)
On 2016/10/27 at 12:19:32, verwaest wrote: > Huh? That's the default setter behavior for special ...
4 years, 1 month ago (2016-10-27 12:39:35 UTC) #7
Toon Verwaest
I would at least drop all of the accessor.cc changes. We have complete control over ...
4 years, 1 month ago (2016-10-28 14:05:21 UTC) #8
Toon Verwaest
lgtm; you'll need to investigate the impact for specific use-cases :)
4 years, 1 month ago (2016-10-28 14:26:04 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2449783006/20001
4 years, 1 month ago (2016-10-28 14:36:30 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-28 14:39:44 UTC) #17
Benedikt Meurer
I don't know how, but according to AWFY, --turbo --ignition-staging took a serious hit with ...
4 years, 1 month ago (2016-10-28 17:17:39 UTC) #18
jochen (gone - plz use gerrit)
On 2016/10/28 at 17:17:39, bmeurer wrote: > I don't know how, but according to AWFY, ...
4 years, 1 month ago (2016-10-28 17:36:56 UTC) #19
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:16:55 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f07421508221dfcca43a6c10ad8e9047f8f8fcdf
Cr-Commit-Position: refs/heads/master@{#40648}

Powered by Google App Engine
This is Rietveld 408576698