Issue 2449753002: base::EmplaceUnique

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2449753002: base::EmplaceUnique (Closed)

Created:
4 years, 1 month ago by tapted

Modified:
3 years, 7 months ago

Reviewers:

CC:
chromium-reviews, tfarina, chrome-apps-syd-reviews_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

base::EmplaceUnique Allows one to omit the template argument when assigning the result of `MakeUnique` directly to a std::unique_ptr. This hurts the brain a bit, but it effectively adds a tightly-controlled conversion operator from a std::tuple to a std::unique_ptr. BUG=

Patch Set 1 #

Patch Set 2 : fix presubmit #

Patch Set 3 : less weird #

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -2 lines)			Patch
	M	ui/views/controls/scroll_view_unittest.cc	View	1 2	3 chunks	+36 lines, -2 lines	0 comments	Download

Depends on Patchset:

Issue 2442223002 Patch 20001

Messages

Total messages: 1 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

tapted

4 years, 1 month ago (2016-10-25 11:33:02 UTC) #1

Description was changed from

==========
base::EmplaceUnique

Allows one to omit the template argument when assigning the result of
`MakeUnique` directly to a std::unique_ptr.

BUG=
==========

to

==========
base::EmplaceUnique

Allows one to omit the template argument when assigning the result of
`MakeUnique` directly to a std::unique_ptr.

This hurts the brain a bit, but it effectively adds a tightly-controlled
conversion operator from a std::tuple to a std::unique_ptr.

BUG=
==========

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages