Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Issue 2449743002: Convert editing/spelling/mixed-paste-*.html with spellcheck_test (Closed)

Created:
4 years, 1 month ago by Xiaocheng
Modified:
4 years, 1 month ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert editing/spelling/mixed-paste-*.html with spellcheck_test This patch converts editing/spelling/mixed-paste-{short,long}.html with spellcheck_test as a preparation of implementing idle time spellchecker, and consolidate them into editing/spelling/mixed_paste.html to better summarize the test cases. BUG=517298 Committed: https://crrev.com/182d74aa04e7fc45263e7ee0496bc35c65659453 Cr-Commit-Position: refs/heads/master@{#427619}

Patch Set 1 #

Patch Set 2 : Rename #

Total comments: 4

Patch Set 3 : Wed Oct 26 14:57:43 JST 2016 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -192 lines) Patch
D third_party/WebKit/LayoutTests/editing/spelling/mixed-paste-long.html View 1 chunk +0 lines, -82 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/spelling/mixed-paste-long-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/spelling/mixed-paste-short.html View 1 chunk +0 lines, -89 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/spelling/mixed-paste-short-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
A third_party/WebKit/LayoutTests/editing/spelling/mixed_paste.html View 1 2 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Xiaocheng
PTAL. CQ seems broken again, so I'm sending the patch to you directly to get ...
4 years, 1 month ago (2016-10-26 02:48:24 UTC) #3
yosin_UTC9
lgtm w/ small nits https://codereview.chromium.org/2449743002/diff/20001/third_party/WebKit/LayoutTests/editing/spelling/mixed_paste.html File third_party/WebKit/LayoutTests/editing/spelling/mixed_paste.html (right): https://codereview.chromium.org/2449743002/diff/20001/third_party/WebKit/LayoutTests/editing/spelling/mixed_paste.html#newcode18 third_party/WebKit/LayoutTests/editing/spelling/mixed_paste.html:18: var longHTML = '<img src="../resources/abe.png"> ...
4 years, 1 month ago (2016-10-26 03:43:20 UTC) #4
Xiaocheng
Committing after following the reviewer's suggestions. https://codereview.chromium.org/2449743002/diff/20001/third_party/WebKit/LayoutTests/editing/spelling/mixed_paste.html File third_party/WebKit/LayoutTests/editing/spelling/mixed_paste.html (right): https://codereview.chromium.org/2449743002/diff/20001/third_party/WebKit/LayoutTests/editing/spelling/mixed_paste.html#newcode18 third_party/WebKit/LayoutTests/editing/spelling/mixed_paste.html:18: var longHTML = ...
4 years, 1 month ago (2016-10-26 05:59:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2449743002/40001
4 years, 1 month ago (2016-10-26 05:59:24 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-10-26 07:09:48 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 07:12:30 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/182d74aa04e7fc45263e7ee0496bc35c65659453
Cr-Commit-Position: refs/heads/master@{#427619}

Powered by Google App Engine
This is Rietveld 408576698