Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Issue 2449723002: MD Settings: Add remapping options for Backspace and Escape (Closed)

Created:
4 years, 1 month ago by michaelpg
Modified:
4 years, 1 month ago
Reviewers:
stevenjb
CC:
chromium-reviews, extensions-reviews_chromium.org, michaelpg+watch-md-settings_chromium.org, jlklein+watch-closure_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, vitalyp+closure_chromium.org, chromium-apps-reviews_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, dbeam+watch-closure_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Add remapping options for Backspace and Escape These keys were added in Options when we added support for remapping to and from these keys. This completes crbug.com/608625 by adding the same options to Settings. BUG=608625 R=stevenjb@chromium.org TEST=Backspace and Escape can be remapped in chrome://md-settings Keyboard settings, and are included in the dropdown of keys to map to. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/4d77b0e6f0b1ee3fc3b9a1ddb268d86f7c29f065 Cr-Commit-Position: refs/heads/master@{#430815}

Patch Set 1 #

Total comments: 2

Patch Set 2 : ModifierKey enum #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -30 lines) Patch
M chrome/app/settings_strings.grdp View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/settings_private/prefs_util.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/device_page/compiled_resources2.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/device_page/keyboard.html View 3 chunks +16 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/device_page/keyboard.js View 1 3 chunks +38 lines, -28 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/webui/settings/device_page_tests.js View 1 2 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
stevenjb
lgtm https://codereview.chromium.org/2449723002/diff/1/chrome/browser/resources/settings/device_page/keyboard.js File chrome/browser/resources/settings/device_page/keyboard.js (right): https://codereview.chromium.org/2449723002/diff/1/chrome/browser/resources/settings/device_page/keyboard.js#newcode66 chrome/browser/resources/settings/device_page/keyboard.js:66: // the chromeos::input_method::ModifierKey enum. optional nit: It would ...
4 years, 1 month ago (2016-10-25 16:49:39 UTC) #2
michaelpg
https://codereview.chromium.org/2449723002/diff/1/chrome/browser/resources/settings/device_page/keyboard.js File chrome/browser/resources/settings/device_page/keyboard.js (right): https://codereview.chromium.org/2449723002/diff/1/chrome/browser/resources/settings/device_page/keyboard.js#newcode66 chrome/browser/resources/settings/device_page/keyboard.js:66: // the chromeos::input_method::ModifierKey enum. On 2016/10/25 16:49:39, stevenjb wrote: ...
4 years, 1 month ago (2016-10-26 02:24:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2449723002/40001
4 years, 1 month ago (2016-11-09 00:36:20 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-09 01:46:38 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-11-09 01:51:39 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4d77b0e6f0b1ee3fc3b9a1ddb268d86f7c29f065
Cr-Commit-Position: refs/heads/master@{#430815}

Powered by Google App Engine
This is Rietveld 408576698