MD Settings: Add remapping options for Backspace and Escape

MD Settings: Add remapping options for Backspace and Escape

These keys were added in Options when we added support for remapping to
and from these keys. This completes crbug.com/608625 by adding the same
options to Settings.

BUG=608625
R=stevenjb@chromium.org
TEST=Backspace and Escape can be remapped in chrome://md-settings Keyboard
     settings, and are included in the dropdown of keys to map to.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/4d77b0e6f0b1ee3fc3b9a1ddb268d86f7c29f065
Cr-Commit-Position: refs/heads/master@{#430815}

[michaelpg, 2016-10-25 01:06:32]

Description was changed from

==========
MD Settings: Add remapping options for Backspace and Escape

These keys were added in Options when we added support for remapping to
and from these keys. This completes crbug.com/608625 by adding the same
options to Settings.

BUG=608625
R=stevenjb@chromium.org
TEST=Backspace and Escape can be remapped in chrome://md-settings Keyboard
     settings, and are included in the dropdown of keys to map to.
==========

to

==========
MD Settings: Add remapping options for Backspace and Escape

These keys were added in Options when we added support for remapping to
and from these keys. This completes crbug.com/608625 by adding the same
options to Settings.

BUG=608625
R=stevenjb@chromium.org
TEST=Backspace and Escape can be remapped in chrome://md-settings Keyboard
     settings, and are included in the dropdown of keys to map to.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[stevenjb, 2016-10-25 16:49:39]

lgtm

https://codereview.chromium.org/2449723002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/device_page/keyboard.js (right):

https://codereview.chromium.org/2449723002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/device_page/keyboard.js:66: // the
chromeos::input_method::ModifierKey enum.
optional nit: It would be nice (but much more verbose) to define a matching JS
enum for these at the top of the file.

[michaelpg, 2016-10-26 02:24:38]

https://codereview.chromium.org/2449723002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/device_page/keyboard.js (right):

https://codereview.chromium.org/2449723002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/device_page/keyboard.js:66: // the
chromeos::input_method::ModifierKey enum.
On 2016/10/25 16:49:39, stevenjb wrote:
> optional nit: It would be nice (but much more verbose) to define a matching JS
> enum for these at the top of the file.

Done. (A bit more verbose, but probably easier to read, and easier to not
break.)

[michaelpg, 2016-11-09 00:35:37]

The CQ bit was checked by michaelpg@chromium.org

[michaelpg, 2016-11-09 00:35:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org
Link to the patchset: https://codereview.chromium.org/2449723002/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2016-11-09 00:36:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-09 01:46:38]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-09 01:51:37]

Description was changed from

==========
MD Settings: Add remapping options for Backspace and Escape

These keys were added in Options when we added support for remapping to
and from these keys. This completes crbug.com/608625 by adding the same
options to Settings.

BUG=608625
R=stevenjb@chromium.org
TEST=Backspace and Escape can be remapped in chrome://md-settings Keyboard
     settings, and are included in the dropdown of keys to map to.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Add remapping options for Backspace and Escape

These keys were added in Options when we added support for remapping to
and from these keys. This completes crbug.com/608625 by adding the same
options to Settings.

BUG=608625
R=stevenjb@chromium.org
TEST=Backspace and Escape can be remapped in chrome://md-settings Keyboard
     settings, and are included in the dropdown of keys to map to.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/4d77b0e6f0b1ee3fc3b9a1ddb268d86f7c29f065
Cr-Commit-Position: refs/heads/master@{#430815}
==========

[commit-bot: I haz the power, 2016-11-09 01:51:39]

Patchset 3 (id:??) landed as
https://crrev.com/4d77b0e6f0b1ee3fc3b9a1ddb268d86f7c29f065
Cr-Commit-Position: refs/heads/master@{#430815}