Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Side by Side Diff: third_party/WebKit/Source/core/timing/Performance.h

Issue 2449673002: Refactor InspectorWebPerfAgent: update lifecycle management to be per Local Frame root; replace hea… (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * Copyright (C) 2012 Intel Inc. All rights reserved. 3 * Copyright (C) 2012 Intel Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
57 } 57 }
58 ~Performance() override; 58 ~Performance() override;
59 59
60 ExecutionContext* getExecutionContext() const override; 60 ExecutionContext* getExecutionContext() const override;
61 61
62 MemoryInfo* memory(); 62 MemoryInfo* memory();
63 PerformanceNavigation* navigation() const; 63 PerformanceNavigation* navigation() const;
64 PerformanceTiming* timing() const override; 64 PerformanceTiming* timing() const override;
65 65
66 void updateLongTaskInstrumentation() override; 66 void updateLongTaskInstrumentation() override;
67 bool observeringLongTasks();
caseq 2016/10/26 21:19:41 typo :)
panicker 2016/10/27 23:06:53 Oops. Fixed.
panicker 2016/10/28 00:09:24 Sorry, this is actually fine. It's the getter. Sho
67 68
68 ScriptValue toJSONForBinding(ScriptState*) const; 69 ScriptValue toJSONForBinding(ScriptState*) const;
69 70
70 DECLARE_VIRTUAL_TRACE(); 71 DECLARE_VIRTUAL_TRACE();
71 72
72 private: 73 private:
73 explicit Performance(LocalFrame*); 74 explicit Performance(LocalFrame*);
74 75
75 mutable Member<PerformanceNavigation> m_navigation; 76 mutable Member<PerformanceNavigation> m_navigation;
76 mutable Member<PerformanceTiming> m_timing; 77 mutable Member<PerformanceTiming> m_timing;
77 mutable Member<InspectorWebPerfAgent> m_longTaskInspectorAgent; 78
79 bool m_observingLongTasks;
78 }; 80 };
79 81
80 } // namespace blink 82 } // namespace blink
81 83
82 #endif // Performance_h 84 #endif // Performance_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698